refactor Dependency.js to es6 #3696
Conversation
|
should the file be moved to |
|
@timse so this one is a little more involved to switch over because it is a top level superclass there are multiple levels of inheritance between this one and any other file that ends in Dependency. So to refactor this one, you would also need to first refactor any file that ends in Dependency. Good example is Dependency => NullDependency => ConstDependency. If your not quite up for that much refactoring that is okay, feel free to close this PR and work on the lower level (in the hierarchy) Dependency subclasses like anything in the dependency folder. Let me know if any of this is unclear. |
|
i guess i need to start at the top of the foodchain here to make this work :) |
|
|
||
| Dependency.compareLocations = require("./compareLocations"); |
There was a problem hiding this comment.
This is technically an API change; nothing left around that assumes it can find compareLocations in the constructor?
|
Closed and reopened to kick off a new build. |
|
checking why this fails! |
dont expose compareLocations as Dependency attribute anymore as its only used internally anyways
its only consumer is the Compilation maybe this should be inlined?
timse
force-pushed
the
refactor-dependency-to-es6
branch
from
b874c58
to
0b0932f
Compare
|
found it. The only user of Dependency.compare seams to be Compilation, maybe we can inline that actually? |
|
Well freaking done!!! That was a huge one. |
|
Wow thank you so much. Would you mind shooting me an email? You can find it on my profile page. I'd like to chat with you briefly <3 |
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
current tests should pass
If relevant, link to documentation update:
N/A
Summary
upgrade Dependency.js to es6
Does this PR introduce a breaking change?
No
Other
Dont expose compareLocations as Dependency attribute anymore as its only used internally anyways