New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Scope Hoisting for correct order and more efficient commonjs interop #5453

Merged
merged 15 commits into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@sokra
Member

sokra commented Aug 7, 2017

What kind of change does this PR introduce?
refactoring + bugfix

Did you add tests for your changes?
yes

If relevant, link to documentation update:
N/A

Summary
fixes #5443
fixes #5288
calls will have the correct this context even with scope hoisting

Does this PR introduce a breaking change?
no

Other information

fix conflict handling
remove unused code

@webpack-bot webpack-bot added PR: CI-not-ok and removed PR: CI-ok labels Aug 7, 2017

sokra added some commits Aug 7, 2017

@webpack-bot

This comment has been minimized.

Show comment
Hide comment
@webpack-bot

webpack-bot Aug 7, 2017

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

webpack-bot commented Aug 7, 2017

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Aug 7, 2017

@sokra sokra merged commit afa28c0 into master Aug 8, 2017

4 of 9 checks passed

codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch 93.24% of diff hit (target 94.97%)
Details
codecov/project 94.93% (-0.04%) compared to e9a8e35
Details
coverage/coveralls Coverage decreased (-0.03%) to 94.992%
Details
codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@sokra sokra deleted the bugfix/import-order-scope-hoisting branch Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment