New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor weird things #5926

Merged
merged 6 commits into from Nov 8, 2017

Conversation

Projects
None yet
2 participants
@sokra
Member

sokra commented Nov 6, 2017

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
existing tests

If relevant, link to documentation update:
N/A

Summary

  • Declare used properties in constructor
  • Module.(re)building moved into Compilation._(re)buildingModules (Map)
  • Make NormalModule.error private
  • Move Module.cacheable logic into needRebuild
  • More stable implemention of rebuildModule
  • addModuleChain waits for Module building finished before returning
  • Set built and cacheable flags correctly in Modules
  • More portableId into WeakMap
  • Add ModuleReason for entrypoints
  • cacheable can be true/false/null in Stats
  • added Stats module issuerPath
  • fixes profile in stats output

Does this PR introduce a breaking change?
yes

Other information

Refactor weird things
* Declare used properties in constructor
* Module.(re)building moved into Compilation._(re)buildingModules (Map)
* Make NormalModule.error private
* Move Module.cacheable logic into needRebuild
* More stable implemention of rebuildModule
* addModuleChain waits for Module building finished before returning
* Set built and cacheable flags correctly in Modules
* More portableId into WeakMap
* Add ModuleReason for entrypoints
* cacheable can be true/false/null in Stats
* added Stats module issuerPath
* fixes profile in stats output

sokra added some commits Nov 6, 2017

@webpack-bot webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Nov 6, 2017

@webpack-bot

This comment has been minimized.

webpack-bot commented Nov 6, 2017

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 4838b6f into next Nov 8, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codecov/changes/integration No unexpected coverage changes found.
Details
codecov/changes/unit No unexpected coverage changes found.
Details
codecov/patch/integration 96.95% of diff hit (target 90%)
Details
codecov/patch/unit 36.63% of diff hit (target 0%)
Details
codecov/project/integration 91.59% (+0.09%) compared to 49cdb94
Details
codecov/project/unit 49.25% (target 0%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 93.741%
Details
licence/cla Contributor License Agreement is signed.
Details

@sokra sokra deleted the refactor/cleanup-stuff branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment