Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ArrayBuffer fallback for #7918 #7983
What kind of change does this PR introduce?
Adds a failure case so Electron-style apps can easily use WebAssembly
Did you add tests for your changes?
Doesn't run a headless test, not sure how best to add test support (is tested using a local Electron app)
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?
Hopefully nothing? Think there may be a README example that needs updating, but this should be something that "just fixes" some background issues.
Alright, continued working with this, and bad news - this patch works fine for
Character 2658 is the actual call to
referenced this pull request
Sep 30, 2018
@TheLarkInn do we know if that's a common issue in pratice?
I'm not personally blocking it, but i'm not happy with the solution. There are many reasons for TypeErrors during
However, the worst case would be to call instantiate twice. I'm pretty sure it won't run two compilations, most of the type mismatch are coming from the ImportObject, which is checked before.
Ideally, either Electron should figure out a way to correctly load Wasm or the mime-type restriction needs to change.