Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding format option for Dll Plugin to get a formatted manifest json. #7992 #8139

Merged
merged 4 commits into from Nov 5, 2018

Conversation

@NaviMarella
Copy link
Contributor

@NaviMarella NaviMarella commented Oct 3, 2018

What kind of change does this PR introduce?

Adding a feature (option) for DLL Plugin to format manifest json output file.

Did you add tests for your changes?

I assume no tests are required.

Does this PR introduce a breaking change?

This doesn't introduce a breaking change.

What needs to be documented once your changes are merged?

  1. Change documentation for DLL Plugin and add a new option called "format" and it's use.

I will make a change to the documentation, to add format options in DLL Plugin documentation.

This Pr is for the issue #7992.

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Oct 3, 2018

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)
@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Oct 3, 2018

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Oct 3, 2018

The minimum test ratio has been reached. Thanks!

lib/DllPlugin.js Outdated Show resolved Hide resolved
@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Oct 4, 2018

@NaviMarella Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra
sokra approved these changes Nov 5, 2018
@sokra sokra merged commit 1ea411b into webpack:master Nov 5, 2018
13 checks passed
13 checks passed
@codecov
codecov/changes/basic No unexpected coverage changes found.
Details
@codecov
codecov/changes/integration No unexpected coverage changes found.
Details
@codecov
codecov/changes/unit No unexpected coverage changes found.
Details
@codecov
codecov/patch/integration 100% of diff hit (target 90%)
Details
@codecov
codecov/patch/unit Coverage not affected when comparing 4c461e2...0140426
Details
@codecov
codecov/project/basic 100% remains the same compared to 4c461e2
Details
@codecov
codecov/project/integration 91.45% (+<.01%) compared to 4c461e2
Details
@codecov
codecov/project/unit 100% (target 0%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
security/snyk - package.json (sokra) No new issues
Details
@azure-pipelines
webpack.webpack Build #20181004.6 succeeded
Details
@sokra
Copy link
Member

@sokra sokra commented Nov 5, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants