Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #8293 #8338

Merged
merged 2 commits into from Nov 5, 2018
Merged

Bugfix for #8293 #8338

merged 2 commits into from Nov 5, 2018

Conversation

@sokra
Copy link
Member

@sokra sokra commented Nov 5, 2018

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

FranckFreiburger and others added 2 commits Nov 5, 2018
walk inner expressions in wrapped context
add tracking of inner expressions in wrapped BasicEvaluatedExpression
fixes #8293
closes ##8337
@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Nov 5, 2018

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)
@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Nov 5, 2018

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit e2a2016 into master Nov 5, 2018
14 checks passed
14 checks passed
@codecov
codecov/changes/basic No unexpected coverage changes found.
Details
@codecov
codecov/changes/integration No unexpected coverage changes found.
Details
@codecov
codecov/changes/unit No unexpected coverage changes found.
Details
@codecov
codecov/patch/basic Coverage not affected when comparing af123a8...babe736
Details
@codecov
codecov/patch/integration 100% of diff hit (target 90%)
Details
@codecov
codecov/patch/unit Coverage not affected when comparing af123a8...babe736
Details
@codecov
codecov/project/basic 100% remains the same compared to af123a8
Details
@codecov
codecov/project/integration 91.44% (+0.02%) compared to af123a8
Details
@codecov
codecov/project/unit 100% (target 0%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
security/snyk - package.json (sokra) No manifest changes detected
@azure-pipelines
webpack.webpack Build #20181105.25 succeeded
Details
@sokra sokra deleted the bugfix/issue-8293 branch Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants