Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Don't recompute filename hash #9709

Merged
merged 1 commit into from Sep 23, 2019

Conversation

@mbudde
Copy link
Contributor

commented Sep 18, 2019

What kind of change does this PR introduce?
A minor code improvement.

Did you add tests for your changes?
There should not be any observable changes to behaviour.

Does this PR introduce a breaking change?
Nope.

What needs to be documented once your changes are merged?
Nothing.

@webpack-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)
@webpack-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra
sokra approved these changes Sep 23, 2019
@sokra sokra merged commit a97e8d6 into webpack:master Sep 23, 2019
27 checks passed
27 checks passed
codecov/changes/basic No unexpected coverage changes found.
Details
codecov/changes/integration No unexpected coverage changes found.
Details
codecov/changes/unit No unexpected coverage changes found.
Details
codecov/patch/basic Coverage not affected when comparing b930486...465922f
Details
codecov/patch/integration Coverage not affected when comparing b930486...465922f
Details
codecov/patch/unit Coverage not affected when comparing b930486...465922f
Details
codecov/project/basic 86.6% remains the same compared to b930486
Details
codecov/project/integration 91.12% remains the same compared to b930486
Details
codecov/project/unit 100% (target 0%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
webpack.webpack Build #20190918.1 succeeded
Details
webpack.webpack (Linux node-10) Linux node-10 succeeded
Details
webpack.webpack (Linux node-12) Linux node-12 succeeded
Details
webpack.webpack (Linux node-6) Linux node-6 succeeded
Details
webpack.webpack (Linux node-8) Linux node-8 succeeded
Details
webpack.webpack (Windows node-10) Windows node-10 succeeded
Details
webpack.webpack (Windows node-12) Windows node-12 succeeded
Details
webpack.webpack (Windows node-6) Windows node-6 succeeded
Details
webpack.webpack (Windows node-8) Windows node-8 succeeded
Details
webpack.webpack (basic) basic succeeded
Details
webpack.webpack (lint) lint succeeded
Details
webpack.webpack (macOS node-10) macOS node-10 succeeded
Details
webpack.webpack (macOS node-12) macOS node-12 succeeded
Details
webpack.webpack (macOS node-6) macOS node-6 succeeded
Details
webpack.webpack (macOS node-8) macOS node-8 succeeded
Details
@sokra

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.