fix(Auto-fix): ignore is not applied - #654
Merged
Merged
Conversation
Contributor
Author
|
Sorry, I'll check the CI error. |
taro-28
marked this pull request as draft
May 26, 2024 10:14
Contributor
Author
I checked and could not reproduce it locally. |
taro-28
marked this pull request as ready for review
May 26, 2024 10:39
webpro
approved these changes
May 26, 2024
webpro
left a comment
webpro
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for this PR! Just a nitpick and I'm happy to merge 🙌
| }); | ||
| if (isType) fixer.addUnusedTypeNode(filePath, exportedItem.fixes); | ||
| else fixer.addUnusedExportNode(filePath, exportedItem.fixes); | ||
| if (issue) { |
Member
There was a problem hiding this comment.
Nitpick: since it's a boolean I'd like to name it isAdded or isIssueAdded
Contributor
Author
There was a problem hiding this comment.
Indeed! I fixed it to isIssueAdded
fffce74
Member
|
Thank you @taro-28, most excellent stuff! |
Member
|
🚀 This pull request is included in v5.17.0-canary.2. See Release 5.17.0-canary.2 for release notes. Using Knip in a commercial project? Please consider sponsoring me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #653
Fixed and added test cases for the following cases
ignore.ignoreWorkspacesfor ignoretagsfor ignoreSince
ignoreMembersis not yet supported by Auto-fix and I thoughtignoreBinarieswas an option unrelated to Auto-fix, I did not include either of them in the test case.