Add nodes to an existing instance

[Wikiki]

Add new nodes based on a selector to an existing instance.

Example:
$( '#div1' ).add( '#div2' )

[coveralls]

Coverage decreased (-1.8%) to 92.6% when pulling e071fad on Wikiki:feature/addNodes into e0991e2 on webpro:master.

[webpro]

What functionality are you missing from .push() (array) and/or e.g. .append() (DOM)?

[Wikiki]

Hi,

I miss the chainability from push and using .append() does not works. If I log the DOMtastic instance after an .append() it's still empty.
And .push() function doesn't return a DOMtastic instance.

Example:

console.log( $().add('.sortable') );           // Display a list of all matching elements
console.log( $().push('.sortable') );         // Display 1
console.log( $().append('.sortable') );     // Display an empty array

regards,

[webpro]

• append indeed doesn't work with a selector: https://domtastic.js.org/doc/#dom/index-append
• push works like Array.prototype.push
• How about a new concat method? Which can be used like this:

$(selector).concat(NodeList);
$('.first').concat($('.second'));
$().concat($('.sortable'));

[Wikiki]

Why not having a new .concat() method instead of a .add() one.

[webpro]

Great idea. Could you please add specs and make sure the code style matches the rest of the project (npm run lint)?

[Wikiki]

Maybe you can help me, it's my first time with mocha.

When I run npm run test on my side it's working perfectly well but when it's run by Travis CI my test does not pass. I got the error TypeError: nodes.indexOf is not a function

[Wikiki]

The problem is only for npm run test:jquery
Any idea why indexOf doesn't work with jquery-compat test ?

[webpro]

The jquery-compat mode has an index method (not indexOf), like jQuery itself; so you can't use this directly. Perhaps something like [].indexOf.call(this, element) is better here.

[webpro]

Please return this; no need to create a new instance?

[Wikiki]

Thanks for your help.
I've made the corrections.

[coveralls]

Coverage decreased (-0.2%) to 94.243% when pulling 3bcea10 on Wikiki:feature/addNodes into e0991e2 on webpro:master.

[Wikiki]

Can I add the following code at the beginning of the method and still compliant with DOMtastic's philosophy:

if ( typeof elements === 'string' ) {
    elements = querySelector( elements );
  }

to be able to concat from a selector ?