Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use subslide as a featured slide #219

Merged
merged 1 commit into from Oct 15, 2018
Merged

Add the ability to use subslide as a featured slide #219

merged 1 commit into from Oct 15, 2018

Conversation

kazigk
Copy link
Contributor

@kazigk kazigk commented Oct 2, 2018

Example usage: reveal-md slides.md --static --featured-slide 1-1

Resolves #206

@webpro
Copy link
Owner

webpro commented Oct 8, 2018

Thanks, @kazigk. Unfortunately, the puppeteer screenshot isn't currently working for me, as I'm getting a white featured-slide.jpg. The print/PDF works fine. Also tried with the latest version of Puppeteer. Maybe it has something to do with an OS update to Mojave.

So I can't try/verify this PR yet. If anyone can confirm this works (and on which OS), that would help.

@kazigk
Copy link
Contributor Author

kazigk commented Oct 8, 2018

Yes, it works

OS: macOS High Sierra 10.13.6
Node version: v10.10.0

@webpro webpro merged commit 357406d into webpro:master Oct 15, 2018
@webpro
Copy link
Owner

webpro commented Oct 15, 2018

Thanks, @kazigk! Released this in v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants