New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option for customizing the chromium executable used by puppeteer #220

Merged
merged 3 commits into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@matthiasharrer
Copy link
Contributor

matthiasharrer commented Oct 8, 2018

Hi,

this adds an cli option to use a different chromium executable than the bundled one installed by puppeteer. It allows to use base images that already come with chrome preinstalled, as it is not easy to get the bundled chromium to run on alpine based images (Run puppeteer in Docker).

The pull request also improves the puppeteer launch args handling as it is now done in one place instead of seperate handling for featured slides and printing.
It also improves the cli help texts for these options.

@webpro webpro merged commit 4242a48 into webpro:master Oct 15, 2018

@webpro

This comment has been minimized.

Copy link
Owner

webpro commented Oct 15, 2018

Thanks, @matthiasharrer! Released this in v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment