New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Render static dir #224

Merged
merged 9 commits into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@skad
Copy link
Contributor

skad commented Nov 29, 2018

Has requested in #164 and need by me

Just use

reveal-md --static for render static from the root
reveal-md dir/ --static for render from a dir

skad added some commits Nov 29, 2018

Adding static render for directory
 - work like the live server
 - use reveal-md --static for render all md into the _static dir
@webpro

This comment has been minimized.

Copy link
Owner

webpro commented Dec 5, 2018

Hi @skad, Thanks for the PR! A few remarks:

  • Please use prettier (npm run format) for formatting.
  • util.promisify is available from Node v8, but reveal-md should run in Node v6. You can bluebird which is already a dependency.
  • There's still an excessive console.log in the tests.

If you can update the PR, I'm happy to merge this.

@skad

This comment has been minimized.

Copy link
Contributor

skad commented Dec 5, 2018

And done

@webpro

This comment has been minimized.

Copy link
Owner

webpro commented Dec 5, 2018

Thanks! I just noticed that the path to the theme stylesheet is broken when opening a directory listing (e.g. reveal-md demo/). Could you please look into this?

@skad skad force-pushed the skad:feature/render-static-dir branch from efa4ac4 to f32ae09 Dec 5, 2018

@webpro webpro merged commit 8cc524f into webpro:master Dec 6, 2018

@webpro

This comment has been minimized.

Copy link
Owner

webpro commented Dec 6, 2018

Thanks @skad! Release in v2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment