Review from Adam Roach #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamroach
reviewed
Jul 11, 2017
| @@ -416,7 +421,7 @@ Shared ECDH secret (ecdh_secret): | |||
|
|
|||
| : kyrL1jIIOHEzg3sM2ZWRHDRB62YACZhhSlknJ672kSs | |||
|
|
|||
| Pseudo-random key for key combining (PRK_key): | |||
| Pseudorandom key (PRK) for key combining (PRK_key): | |||
There was a problem hiding this comment.
Note that this is still a backwards reference, as "PRK" appears earlier in the document.
There was a problem hiding this comment.
That's true, but this is the first time we have prose on which this can be attached. The uses earlier in the document are just symbols in "code".
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For @adamroach