SECDIR review #16
Merged
SECDIR review #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beverloo
approved these changes
Jul 26, 2017
draft-ietf-webpush-encryption.md
Outdated
| authenticated and provides confidentiality and integrity, such as HTTPS | ||
| {{?RFC2818}}, is sufficient. | ||
| an Application Server that can be used to initiate and secure communications for | ||
| key distribution. Any existing communication mechanism that is authenticated |
There was a problem hiding this comment.
What about simplifying to "that can be used for key distribution", as the following sentence describes the security aspects of the communication channel?
It might be worthwhile to explicitly mention the endpoint too -- especially if subscription restrictions are not being used, the security aspects of the channel used to communicate the endpoint (which otherwise relies on endpoint secrecy) should be identical.
There was a problem hiding this comment.
Yeah, I'll make this "subscription data" instead. Keys are critical, but the rest of the subscription information is similarly important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.