Why limit expiration #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beverloo
approved these changes
Jun 30, 2017
draft-ietf-webpush-vapid.md
Outdated
| an attacker and can increase the difficulty of stealing a token. | ||
| an attacker and can increase the difficulty of stealing a token. Placing a | ||
| hard upper limit on the "exp" claim in the JWT allows a push service to reject | ||
| tokens that have excessively long expiration times. |
There was a problem hiding this comment.
I'm not entirely convinced about the value of this addition. It's normatively required (the MUST NOT on line 145) and already implied by the sentence directly above ("applying narrow limits"), as it would not make sense if the PS was free to ignore this requirement. It's clear though, so SGTM from that point of view.
There was a problem hiding this comment.
Yeah, I'm going to cut this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
From the secdir review by Robert Sparks.