For @ekr #43
Closed
For @ekr #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekr
reviewed
Aug 16, 2017
| It's not shouting, when they are capitalized, they have the special meaning | ||
| described in {{!RFC2119}}. | ||
| When they are capitalized, they have the special meaning described in | ||
| {{!RFC2119}}. |
beverloo
approved these changes
Aug 17, 2017
| payloads. In situations where usage of a subscription can be limited to a | ||
| single application server, the ability to associate a subscription with the | ||
| application server could reduce the impact of a data leak. | ||
| Additionally, the design of RFC 8030 relies on maintaining the secrecy of push |
There was a problem hiding this comment.
Should RFC 8030 be a reference?
| request for push message delivery MUST include proof of possession for the | ||
| associated private key that was used when creating the push subscription. | ||
| request for push message delivery MUST include a JWT signed by the private key | ||
| that was used when creating the push subscription. |
There was a problem hiding this comment.
Is it correct to refer to the private key that was used to create the subscription, when that is done using a public key that was derived from the private key?
What about:
When a push subscription has been restricted to an application server, the
request for push message delivery MUST include a valid JWT signed by the
private key paired with the public key used when creating the push subscription.
|
Merged manually after resolving conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This doesn't address the suggested alternative design.