FirebirdDB __init__ needs to be fixed #177

merged 2 commits into from Aug 20, 2012


None yet
3 participants

benthepoet commented Aug 19, 2012

DB.insert was broken for FirebirdDB because the paramstyle was defaulting to 'pyformat'. Kinterbasdb expects 'qmark'. Setting paramstyle from the db object fixes this.

The password keyword is also wrong. Is being set as 'passwd', kinterbasdb looks for 'password'. Also re-wrote the keyword setting for 'database' and 'password' to use pop() instead of deleting the key manually. This keeps it consistent with how keywords are being set on the other drivers.

Ben Hanna Set paramstyle for FirebirdDB, was defaulting to pyformat and broke D…
…B.insert. Kinterbasdb expects qmark.

This pull request passes (merged a807b63 into 914ceb7).

Ben Hanna Password keyword for FirebirdDB was wrong, was passwd should be passw…
…ord. Corrected syntax for setting the database and password keywords. Now uses pop() to maintain consistency with the other drivers.

This pull request fails (merged 6e36b87 into 914ceb7).

This pull request fails (merged 6e36b87 into 914ceb7).


aaronsw commented Aug 20, 2012

I don't have it, so I'll take your word for it.

@aaronsw aaronsw added a commit that referenced this pull request Aug 20, 2012

@aaronsw aaronsw Merge pull request #177 from benthepoet/master
FirebirdDB __init__ needs to be fixed

@aaronsw aaronsw merged commit 875ef3d into webpy:master Aug 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment