Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some bug fix and improvement #65

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
  1. lazy import template, db, and so on.
  2. translate mapping from tuple to list when initial
  3. setcookie's argument name should convert to str (not unicode)
  4. add __contains__ method in session.py
  5. use function instead of class for memoize
Contributor

anandology commented Jun 21, 2011

@lovelylain thanks for the patches. Pulled 2,3 and 4. I'm rejecting 1 as it is full of magic.

What is the advantage of making memoize a function instead of a class?

@anandology I think function is a litter faster than class.
Because re module will automatically cache some regexps, when I have not many regexps, re_compile is a litter slower than re.compile.
Anyway, the difference is small, there is no need to merge it.

@lovelylain lovelylain closed this Jun 21, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment