Skip to content

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Feb 3, 2023

Hides "Crawl Configs" and "Browser Profile" for viewer roles, + some minor type file reorganizing. Resolves #525.

Manual testing

  1. Log in as a user with a "viewer" role. Verify only the "Crawls" top-level navigation tab is shown.
  2. Log out and log in as user with "crawler" role. Verify "Crawls", "Crawl Configs", and "Browser Profiles" is shown.
  3. Log out and log in as an org owner. Verify all crawler tabs + "Org Settings" is shown.

@SuaYoo SuaYoo requested a review from ikreymer February 3, 2023 05:20
@@ -0,0 +1,110 @@
export type CrawlState =
Copy link
Member Author

@SuaYoo SuaYoo Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is essentially a copy-paste from frontend/src/pages/org/types.ts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, so just moving to more generic location.

@SuaYoo SuaYoo force-pushed the frontend-update-tab-access branch from 1096622 to 1d6331e Compare February 3, 2023 05:43
@SuaYoo SuaYoo force-pushed the frontend-update-tab-access branch from 1d6331e to 252ff9a Compare February 3, 2023 05:46
@ikreymer ikreymer merged commit 10c96ed into main Feb 3, 2023
@ikreymer ikreymer deleted the frontend-update-tab-access branch February 3, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only show 'Crawl Configs' and 'Profiles' tabs for 'crawler' role or higher

3 participants