Make btrix helper work with microk8s #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, made a few additional changes but this should be ready now, at least for the moment. Was good to test on my linux box and see where a few changes were necessary. |
ikreymer
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the
btrixdev helper to determine ifmicrok8sis installed, and if so prefaces allhelmandkubectlcommands with microk8s. This makes it so that the same commands work regardless of whether the user is using Docker Desktop or microk8s (in Ubuntu/pop_os).Additionally, Python commands should use
python3rather thanpythonto cast a wide net/not require python3-as-python on user machines.