New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample Apache configuration #374

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@anarcat

anarcat commented Aug 30, 2018

Description

This patch updates the documentation to add a configuration snippet
for Apache.

Motivation and Context

This configuration can be used when launching wayback in the default
configuration, which is useful to add stuff like access control,
authentication, or encryption without going through the trouble of
setting up a UWSGI proxy.

The force_scheme configuration wouldn't be necessary if pywb would
support the (de-facto) standard X-Forwarded-Proto header. This is
not, unfortunately, currently the case so the configuration cannot be
only on Apache's side. Note that this is similar to the concerns raised in #314

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.
add sample Apache configuration
This configuration can be used when launching `wayback` in the default
configuration, which is useful to add stuff like access control,
authentication, or encryption without going through the trouble of
setting up a UWSGI proxy.
@anarcat

This comment has been minimized.

Show comment
Hide comment
@anarcat

anarcat Aug 30, 2018

Also note that I've tried to use UWSGI with Apache, but ultimately failed. The procedure I follow, on Debian Buster, was to install the uwsgi-core and uwsgi-plugin-python packages, then run:

uwsgi --plugin python uwsgi.ini

Then, on the server, I tried to configure the proxy with:

ProxyPass "/" "uwsgi://localhost:8080/"
ProxyPassReverse "/" "uwsgi://localhost:8080/"

It yielded a 500 internal server error after a ~10 seconds time, without anything particular in the logs, on the server or uwsgi side. Not sure what's up with that...

anarcat commented Aug 30, 2018

Also note that I've tried to use UWSGI with Apache, but ultimately failed. The procedure I follow, on Debian Buster, was to install the uwsgi-core and uwsgi-plugin-python packages, then run:

uwsgi --plugin python uwsgi.ini

Then, on the server, I tried to configure the proxy with:

ProxyPass "/" "uwsgi://localhost:8080/"
ProxyPassReverse "/" "uwsgi://localhost:8080/"

It yielded a 500 internal server error after a ~10 seconds time, without anything particular in the logs, on the server or uwsgi side. Not sure what's up with that...

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 30, 2018

Codecov Report

Merging #374 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   87.56%   87.59%   +0.02%     
==========================================
  Files          59       59              
  Lines        7078     7078              
  Branches     1253     1253              
==========================================
+ Hits         6198     6200       +2     
+ Misses        594      593       -1     
+ Partials      286      285       -1
Impacted Files Coverage Δ
pywb/manager/autoindex.py 91.13% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52fdee...f18aa5b. Read the comment docs.

codecov bot commented Aug 30, 2018

Codecov Report

Merging #374 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   87.56%   87.59%   +0.02%     
==========================================
  Files          59       59              
  Lines        7078     7078              
  Branches     1253     1253              
==========================================
+ Hits         6198     6200       +2     
+ Misses        594      593       -1     
+ Partials      286      285       -1
Impacted Files Coverage Δ
pywb/manager/autoindex.py 91.13% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52fdee...f18aa5b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment