Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upExtend delimiters for tag values #61
Conversation
This comment has been minimized.
This comment has been minimized.
Rebased and passing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
xiam commentedNov 13, 2019
•
edited
@pkieltyka accepting spaces and handling cases like:
would be problematic from the parser's point of view (because identifying a comment would depend on the context and we'll have to ask things like is this the last
#
preceded by[whitespace]
on this line?)What we can do to solve this problem is to look for [whitespace] or [newline] to mark the end of a token, and also add support for quoted values that may include [whitespace]. See below:
What do you think?
Closes #60