This repository was archived by the owner on Aug 23, 2022. It is now read-only.
allow acceptance of existing channels #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 14.96% 15.06% +0.09%
==========================================
Files 7 7
Lines 3307 3299 -8
Branches 960 960
==========================================
+ Hits 495 497 +2
+ Misses 2528 2518 -10
Partials 284 284
Continue to review full report at Codecov.
|
melekes
added a commit
to melekes/webrtc
that referenced
this pull request
Jul 20, 2022
Allows for acceptance of already created data channels. Duplicates logic already existing in pion at https://github.com/pion/webrtc/blob/master/sctptransport.go#L162. Refs webrtc-rs/data#14 Replaces webrtc-rs#219 Co-authored-by: stuqdog <ethanrodkin@protonmail.com>
melekes
added a commit
to webrtc-rs/webrtc
that referenced
this pull request
Jul 21, 2022
* update call to DataChannel::accept as per data pr #14 Allows for acceptance of already created data channels. Duplicates logic already existing in pion at https://github.com/pion/webrtc/blob/master/sctptransport.go#L162. Refs webrtc-rs/data#14 Replaces #219 Co-authored-by: stuqdog <ethanrodkin@protonmail.com> * bump data and sctp crates versions Co-authored-by: stuqdog <ethanrodkin@protonmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(implements pion commit pion/datachannel@9710006. An associated PR for the webrtc repo will follow)
This allows negotiated channels to be fetched when created out of band of SDP by providing SCTP with a list of already created channels. This also includes a fix to Dial which will return a stream if already exists under the given stream id.