This repository was archived by the owner on Aug 23, 2022. It is now read-only.
add PollDataChannel - impl AsyncRead & AsyncWrite #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 14.68% 15.01% +0.33%
==========================================
Files 7 7
Lines 3269 3310 +41
Branches 940 958 +18
==========================================
+ Hits 480 497 +17
- Misses 2524 2530 +6
- Partials 265 283 +18
Continue to review full report at Codecov.
|
4 tasks
melekes
commented
Jun 8, 2022
melekes
force-pushed
the
anton/async-read-write-for-data-channel
branch
from
c7b6f47 to
1dbe2a4
Compare
tests sometimes hang without them on CI
k0nserv
approved these changes
Jun 15, 2022
Member
k0nserv
left a comment
k0nserv
left a comment
There was a problem hiding this comment.
All good, small comment about the tests
| let mut poll_dc0 = PollDataChannel::new(dc0.clone()); | ||
| let mut poll_dc1 = PollDataChannel::new(dc1.clone()); | ||
|
|
||
| sbuf[0..4].copy_from_slice(&1u32.to_be_bytes()); |
Member
There was a problem hiding this comment.
Perhaps using a more "tricky" value than 1 here would be more robust. e.g. a random value with bits set in all octets such as 961666284
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes webrtc-rs/webrtc#110