This repository was archived by the owner on Aug 23, 2022. It is now read-only.
implement tokio's AsyncRead and AsyncWrite for Stream #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calling poll on a stream directly is incorrect because the object is destroyed every time the function exits
also, implement Clone, Debug and AsRef and comment out AsyncWrite for now
also add a test
This was referenced Apr 17, 2022
tomaka
reviewed
Apr 19, 2022
tomaka
reviewed
Apr 19, 2022
tomaka
reviewed
Apr 19, 2022
webrtc-rs#9 (comment) BEFORE: if `temp_buf.len()` is greater than `buf.remaining()`, than we're loosing some data in `temp_buf`. AFTER: if `temp_buf.len()` is greater than `buf.remaining()`, than we're switching to a special variant of `ReadFut` - `RemainingData(Vec<u8>)`. When another poll_read comes in, remaining data is used to populate `buf`.
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 59.06% 59.05% -0.02%
==========================================
Files 48 48
Lines 4964 5016 +52
Branches 1486 1502 +16
==========================================
+ Hits 2932 2962 +30
- Misses 654 659 +5
- Partials 1378 1395 +17
Continue to review full report at Codecov.
|
4 tasks
melekes
added a commit
to melekes/webrtc-data
that referenced
this pull request
Apr 27, 2022
melekes
added a commit
to melekes/webrtc-data
that referenced
this pull request
Apr 27, 2022
melekes
added a commit
to melekes/webrtc-data
that referenced
this pull request
Jun 15, 2022
algesten
pushed a commit
to webrtc-rs/webrtc
that referenced
this pull request
Aug 23, 2022
algesten
pushed a commit
to webrtc-rs/webrtc
that referenced
this pull request
Aug 23, 2022
webrtc-rs/sctp#9 (comment) BEFORE: if `temp_buf.len()` is greater than `buf.remaining()`, than we're loosing some data in `temp_buf`. AFTER: if `temp_buf.len()` is greater than `buf.remaining()`, than we're switching to a special variant of `ReadFut` - `RemainingData(Vec<u8>)`. When another poll_read comes in, remaining data is used to populate `buf`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes webrtc-rs/webrtc#110