update call to DataChannel::accept as per data pr #14 #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
reviewed
Jul 15, 2022
| let mut existing_data_channels = Vec::new(); | ||
| for dc in dcs.iter() { | ||
| if let Some(dc) = dc.data_channel.lock().await.clone() { | ||
| let dc2 = dc.as_ref().clone(); |
Contributor
There was a problem hiding this comment.
why the second clone? if it's an already cloned object
Contributor
Author
There was a problem hiding this comment.
Yeah, good question! The clone() should be to_owned() instead.
melekes
reviewed
Jul 15, 2022
| async fn accept_data_channels(param: AcceptDataChannelParams) { | ||
| let dcs = param.data_channels.lock().await; | ||
| let mut existing_data_channels = Vec::new(); | ||
| for dc in dcs.iter() { |
Contributor
There was a problem hiding this comment.
Also one idea I just had is to modify DataChannel::accept to accept a reference to a list of existing data channels. That way we won't need to clone all of them, just the one with matching identifier.
Contributor
Author
There was a problem hiding this comment.
👍 will make a PR to update there.
melekes
added a commit
to melekes/webrtc
that referenced
this pull request
Jul 20, 2022
Allows for acceptance of already created data channels. Duplicates logic already existing in pion at https://github.com/pion/webrtc/blob/master/sctptransport.go#L162. Refs webrtc-rs/data#14 Replaces webrtc-rs#219 Co-authored-by: stuqdog <ethanrodkin@protonmail.com>
melekes
added a commit
that referenced
this pull request
Jul 21, 2022
* update call to DataChannel::accept as per data pr #14 Allows for acceptance of already created data channels. Duplicates logic already existing in pion at https://github.com/pion/webrtc/blob/master/sctptransport.go#L162. Refs webrtc-rs/data#14 Replaces #219 Co-authored-by: stuqdog <ethanrodkin@protonmail.com> * bump data and sctp crates versions Co-authored-by: stuqdog <ethanrodkin@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for acceptance of already created data channels. Duplicates logic already existing in pion at https://github.com/pion/webrtc/blob/master/sctptransport.go#L162.
Note that this is a sibling(niece?) pr of webrtc-rs/data#14; it relies on that pr and won't compile until that pr is merged.