update call to DataChannel::accept as per data pr #14 #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for acceptance of already created data channels. Duplicates logic already existing in pion at https://github.com/pion/webrtc/blob/master/sctptransport.go#L162. Refs webrtc-rs/data#14 Replaces webrtc-rs#219 Co-authored-by: stuqdog <ethanrodkin@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 44.01% 43.75% -0.27%
==========================================
Files 68 69 +1
Lines 9721 9785 +64
Branches 2827 2836 +9
==========================================
+ Hits 4279 4281 +2
- Misses 3358 3415 +57
- Partials 2084 2089 +5
Continue to review full report at Codecov.
|
k0nserv
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for acceptance of already created data channels. Duplicates logic
already existing in pion at
https://github.com/pion/webrtc/blob/master/sctptransport.go#L162.
Refs webrtc-rs/data#14
Replaces #219
Co-authored-by: stuqdog ethanrodkin@protonmail.com