Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandate the ALPN value #229

Merged
merged 3 commits into from Sep 19, 2019
Merged

Mandate the ALPN value #229

merged 3 commits into from Sep 19, 2019

Conversation

pthatcherg
Copy link
Contributor

@pthatcherg pthatcherg commented Sep 16, 2019 •
edited by pr-preview bot

baylesj
baylesj suggested changes Sep 16, 2019
View reviewed changes
index.bs Outdated Show resolved Hide resolved
mfoltzgoogle
mfoltzgoogle reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@mfoltzgoogle mfoltzgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with baylesj@'s suggested changes addressed.

@mfoltzgoogle mfoltzgoogle changed the base branch from gh-pages to master September 18, 2019 23:53
@mfoltzgoogle mfoltzgoogle merged commit 6da84e0 into master Sep 19, 2019
@mfoltzgoogle
Copy link
Contributor

Made the suggested changes, rebased and merged.

@mfoltzgoogle mfoltzgoogle mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfoltzgoogle mfoltzgoogle mfoltzgoogle left review comments

@baylesj baylesj baylesj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pthatcherg @mfoltzgoogle @baylesj