New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: feature/465 #272

Closed
wants to merge 19 commits into
base: dev
from

Conversation

Projects
None yet
2 participants
@jaswrks
Member

jaswrks commented Aug 24, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Aug 25, 2016

2016-08-24_19-08-45

@jaswrks

This comment has been minimized.

Member

jaswrks commented Aug 25, 2016

2016-08-24_19-27-27

@jaswrks

This comment has been minimized.

Member

jaswrks commented Aug 25, 2016

@raamdev This is ready for review.

  • I performed some basic tests against WordPress core.
  • No tests performed against ManageWP yet however.
@raamdev

This comment has been minimized.

Member

raamdev commented Aug 25, 2016

Woohoo!! I'll run this through a bunch of tests soon. Awesome work! 😁

@raamdev

This comment has been minimized.

Member

raamdev commented Sep 1, 2016

When there are no Update Credentials filled in, the "Update Available" link still leads to /wp-admin/update-core.php, which is confusing because Comet Cache Pro will not appear in the update list when there are no Update Credentials filled in.

2016-08-31_23-28-24

Maybe the "Update Available" link should instead produce a JavaScript popup message that says to fill in your Update Credentials and save the options first.

@raamdev

This comment has been minimized.

Member

raamdev commented Sep 1, 2016

@jaswsinc I'm having trouble getting the update notification to show up at all... I built a version of this branch with an old version number (v160701) and I saved my Update Credentials, but nothing shows up as a way for me to update...

@raamdev

This comment has been minimized.

Member

raamdev commented Sep 1, 2016

↑ Scratch that.

I hit the "Check Again" button on the WordPress Updates page and now the Comet Cache Pro update appears as expected. I guess I just didn't wait long enough for that routine to run via WP Cron.

2016-08-31_23-45-00
2016-08-31_23-46-21

@raamdev

This comment has been minimized.

Member

raamdev commented Sep 1, 2016

Tested with ManageWP; works great!

2016-09-01_00-34-50

@raamdev raamdev added in progress and removed ready for review labels Sep 2, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Sep 2, 2016

which is confusing because Comet Cache Pro will not appear in the update list when there are no Update Credentials filled in.

Correct.

Maybe the "Update Available" link should instead produce a JavaScript popup message that says to fill in your Update Credentials and save the options first.

Agree with that idea.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Sep 2, 2016

I'm taking a closer look at this now.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Sep 2, 2016

2016-09-02_10-51-46

@jaswrks jaswrks added ready to merge and removed in progress labels Sep 2, 2016

@raamdev

This comment has been minimized.

Member

raamdev commented Sep 2, 2016

@jaswsinc If the wrong credentials are entered, or if you have credentials entered and then you clear the credentials after a new version of Comet Cache Pro is detected, attempting to update results in the following confusing and misleading error:

2016-09-02_15-45-43

Is there anything we can do to make that message clearer?

@raamdev raamdev added in progress and removed ready to merge labels Sep 2, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Sep 2, 2016

I'm not sure, but that's a good idea to check. I'd suggest putting that into a new issue and we can investigate to see if there is another hook that can use to try and catch a scenario like this in core; i.e., where it uses the details that we are giving it.

@raamdev

This comment has been minimized.

Member

raamdev commented Sep 2, 2016

I'd suggest putting that into a new issue

@jaswsinc Done. Thanks! websharks/comet-cache#826

@raamdev raamdev added ready to merge and removed in progress labels Sep 2, 2016

@raamdev raamdev closed this Sep 2, 2016

@raamdev raamdev deleted the feature/465 branch Sep 2, 2016

raamdev added a commit to websharks/comet-cache that referenced this pull request Sep 17, 2016

Phing release of v160917 with the following changes:
- **New Feature** (Lite): The Clear Cache button is now available in the Admin Toolbar for the Lite version of Comet Cache.
- **New Feature** (Pro): Comet Cache Pro is now fully compatible with [WordPress Automatic Background Updates](https://codex.wordpress.org/Configuring_Automatic_Background_Updates#Plugin_.26_Theme_Updates_via_Filter). If you enable automatic background updates for plugins, and you save valid Comet Cache Pro License Credentials in the _Comet Cache Pro → Plugin Options → Update Credentials_ panel, you will automatically receive Pro plugin updates. Props @jaswsinc. See [Issue #289](#289).
- **Bug Fix**: In some scenarios Comet Cache might produce a false-positive "Warning: mkdir(): File exists" message when checking if the cache directory exists. Comet Cache now calls `clearstatcache()` and uses `file_exists()` instead of `is_dir()` to help make this check more robust. See [Issue #786](#786).
- **Bug Fix**: Fixed a bug where the Comet Cache PHP requirements check would fail and produce a fatal error when upgrading from a version of Comet Cache that did not require an extension that is now required by newer releases. This would occur when, for example, the required PHP `mbstring` extension was missing. Props @jaswsinc for finding the bug. See [Issue #817](#817).
- **Bug Fix**: Fixed a bug where upgrading from v160521 would result in the Client-Side Cache option being reset to the default (disabled). If you enabled the Client-Side Cache at some point, now is a good time to double-check that it's still enabled. This bug fix also improves the reliability of all version upgrade routines that Comet Cache runs during upgrades. See [Issue #807](#807).
- **Compatibility / Bug Fix**: The automatic Clear Cache routines that cleared the entire cache automatically whenever _WordPress Dashboard → Settings → General_ was updated, were being too aggressive and not taking into consideration other plugins that might also be using the same `options-general.php` URL. As a result, the entire cache was being unnecessarily cleared when the settings for those other plugins were saved. Props to @futtta from Autoptimize for reporting. See [Issue #825](#825).
- **UI Enhancement:** Adjusted option page font styles for WordPress v4.6 to better match existing style. See [Issue #271](websharks/comet-cache-pro#271).
- **ManageWP Compatibility** (Pro): Comet Cache Pro is now compatible with ManageWP, a service that allows remote management of multiple WordPress sites. Comet Cache Pro Plugin Updates will now appear in the ManageWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the ManageWP Dashboard. Props @jaswsinc. See [Issue #465](#465).
- **InfiniteWP Compatibility** (Pro): Comet Cache Pro is now compatible with InfiniteWP, an application that allows you to manage multiple WordPress sites from a single location. Comet Cache Pro Plugin Updates will now appear in the InfiniteWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the InfiniteWP Dashboard. See [Issue #394](#394).
- **Rewritten Pro Plugin Updater**: The Comet Cache Pro Plugin Updater has been redesigned to use the built-in WordPress plugin updater system. When a Comet Cache Pro update is available, it now appears in the WordPress Updates section and in the Plugins list, like other WordPress plugins and can be updated normally like other WordPress plugins, as long as you have saved valid Comet Cache Pro license details in the new "Update Credentials" options panel. Props @jaswsinc. See [Issue #272](websharks/comet-cache-pro#272).
- **Code Style**: The `WP_CACHE` line that gets inserted into the `wp-config.php` file to enable caching now follows the [WordPress PHP Code Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/). Props @szepeviktor. See [Issue #799](#799).
- **Compatibility** (Pro): When the Autoptimize plugin is active, the Comet Cache Pro HTML Compressor panel now shows a friendly notice explaining that both the HTML Compressor and Autoptimize should not be enabled at the same time because they both address the same performance improvements. The rest of Comet Cache works great alongside Autoptimize and whether you use the HTML Compressor or Autoptimize is a matter of preference. Props to @futtta from Autoptimize for the continued collaboration.
@raamdev

This comment has been minimized.

Member

raamdev commented Sep 17, 2016

Comet Cache v160917 has been released and includes changes from this GitHub Issue. See the v160917 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#272).

@websharks websharks locked and limited conversation to collaborators Sep 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.