Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Reduce Auto-Purge Overhead #130

Closed
jaswrks opened this Issue Apr 26, 2014 · 7 comments

Comments

Projects
None yet
2 participants
Owner

jaswrks commented Apr 26, 2014

I think it would help to reduce overhead if each of the purging routines cached (statically) the fact that they have purged X, Y, or Z, etc... to prevent any one routine from running multiple times in a single process; i.e. whenever any WP hooks may overlap.

For instance, in the auto_purge_post_cache() routine, we could cache the fact that we've already purged post ID 123 and 456 to prevent an overlapping hook from scanning the cache directory again on a repeat call within the same process.

@raamdev raamdev modified the milestones: Next Release, Future Release Apr 28, 2014

Owner

raamdev commented Apr 28, 2014

Great idea! I'll add this to the Future Release milestone, as I'd like to get the next release out ASAP and this performance improvement can wait.

@raamdev raamdev added todo and removed enhancement labels Apr 30, 2014

Owner

jaswrks commented Jun 9, 2014

@raamdev Would you like me to work on this?

Owner

raamdev commented Jun 9, 2014

@jaswsinc That would be great! Thank you.

Owner

jaswrks commented Jun 9, 2014

Great, assigning this to me.

@jaswrks jaswrks self-assigned this Jun 9, 2014

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Jun 12, 2014

jaswrks pushed a commit that referenced this issue Jun 12, 2014

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Jun 12, 2014

jaswrks pushed a commit that referenced this issue Jun 12, 2014

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Jun 12, 2014

jaswrks pushed a commit that referenced this issue Jun 12, 2014

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Jun 12, 2014

jaswrks pushed a commit that referenced this issue Jun 12, 2014

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Jun 13, 2014

jaswrks pushed a commit that referenced this issue Jun 13, 2014

Owner

raamdev commented Jun 18, 2014

@jaswsinc Can you confirm this has been closed by #217 or #218? PR #217 mentioned "Additional work toward achieving websharks/quick-cache#130", but doesn't specifically say that it resolves it.

Owner

jaswrks commented Jun 18, 2014

Yes, this was resolved for the most part in the feature/130 branch; and then more work was completed later in the feature/151 branch; both of these have been merged now; so this could be closed.

Owner

raamdev commented Jun 18, 2014

Closed by #218.

@raamdev raamdev closed this Jun 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment