Clear Cache on Multisite w/ Sub-Directories Not Working #39

Closed
raamdev opened this Issue Dec 20, 2013 · 15 comments

Comments

Projects
None yet
4 participants
@raamdev
Owner

raamdev commented Dec 20, 2013

@sboq writes in #25:

I have 2 Multisite test environments. One is with the subdomains and the other with subfolders. The first one (subdomains) works perfectly, but the other one (subfolders) has the problems as described in this thread by @mrkeyboard, i.e. deleting the cache for individual site doesn't work on the Multisite subfolder installation. It will clear the cache for the individual page/post if it gets updated, including the Home & Posts page purging. But it won't work when I hit the clear cache button, the same message appears as @mrkeyboard explained with the screenshot.

Update: I've tested this with all other plugins deactivated but it still didn't work.
Deleting the cache for individual site doesn't work on the Multisite subfolder installation.

@sboq Can you tell me where you're activating Quick Cache in your multisite environment? Are you Network Activating it from the Network Admin? When you're trying to clear the cache on a child site, are you doing this while logged in as a Super Admin? Any screenshots or further information you can you provide would be greatly appreciated.

@Slobork

This comment has been minimized.

Show comment Hide comment
@Slobork

Slobork Dec 21, 2013

@raamdev I am activating the QC Network wide.
I'm clearing the cache as a Super Admin. Currently I do not have other users on this installation.
Regarding the screenshot it's the same thing as one of the users reported in the issue #25.

Slobork commented Dec 21, 2013

@raamdev I am activating the QC Network wide.
I'm clearing the cache as a Super Admin. Currently I do not have other users on this installation.
Regarding the screenshot it's the same thing as one of the users reported in the issue #25.

@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 21, 2013

Owner

@raamdev I believe this issue has already been solved by 9bfe5ca
It's just not in the official release yet.

Owner

jaswrks commented Dec 21, 2013

@raamdev I believe this issue has already been solved by 9bfe5ca
It's just not in the official release yet.

@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 21, 2013

Owner

@raamdev There is a pending pull request against the Quick-Cache-Pro repo that needs to be merged also.
WebSharks/Quick-Cache-Pro#4

Owner

jaswrks commented Dec 21, 2013

@raamdev There is a pending pull request against the Quick-Cache-Pro repo that needs to be merged also.
WebSharks/Quick-Cache-Pro#4

@raamdev

This comment has been minimized.

Show comment Hide comment
@raamdev

raamdev Dec 23, 2013

Owner

@jaswsinc I tested 9bfe5ca in Quick Cache Pro against a site running Multisite with sub-folders and clicking "Clear Cache" from the admin bar while on the Dashboard for a Child Site clears the entire cache, for all sites, not just for that Child Site.

It seems that @sboq has tested Quick Cache running in a Multisite environment with sub-domains and it sounds like clicking "Clear Cache" while on the Dashboard for a Child Site is clearing that individual site's cache (the behavior I'd expect in both cases).

I haven't tested Multisite running with sub-domains yet, but I'll be setting up a test environment shortly to confirm the current behavior.

Owner

raamdev commented Dec 23, 2013

@jaswsinc I tested 9bfe5ca in Quick Cache Pro against a site running Multisite with sub-folders and clicking "Clear Cache" from the admin bar while on the Dashboard for a Child Site clears the entire cache, for all sites, not just for that Child Site.

It seems that @sboq has tested Quick Cache running in a Multisite environment with sub-domains and it sounds like clicking "Clear Cache" while on the Dashboard for a Child Site is clearing that individual site's cache (the behavior I'd expect in both cases).

I haven't tested Multisite running with sub-domains yet, but I'll be setting up a test environment shortly to confirm the current behavior.

@raamdev

This comment has been minimized.

Show comment Hide comment
@raamdev

raamdev Dec 23, 2013

Owner

@jaswsinc I have confirmed the behavior that I explained in my previous comment with sub-domain multisite installs: When pressing "Clear Cache" on the Admin Bar from the Dashboard of a Child Site, only that child site's cache is cleared (expected behavior).

When doing the same thing from the Dashboard on a Child Site under a sub-directory install, the entire cache is deleted, for all sites, including the parent site (unexpected behavior).

Owner

raamdev commented Dec 23, 2013

@jaswsinc I have confirmed the behavior that I explained in my previous comment with sub-domain multisite installs: When pressing "Clear Cache" on the Admin Bar from the Dashboard of a Child Site, only that child site's cache is cleared (expected behavior).

When doing the same thing from the Dashboard on a Child Site under a sub-directory install, the entire cache is deleted, for all sites, including the parent site (unexpected behavior).

@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 24, 2013

Owner

@raamdev Roger that. I'll take another look at this.

Owner

jaswrks commented Dec 24, 2013

@raamdev Roger that. I'll take another look at this.

@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 24, 2013

Owner

When doing the same thing from the Dashboard on a Child Site under a sub-directory install, the entire cache is deleted, for all sites, including the parent site (unexpected behavior).

@raamdev I just tested the latest development copy (with all pull requests merged in) and I was unable to reproduce this on a sub-directory install (e.g. it's working as expected; clearing only the cache for the current blog you're on). I'm running a sub-directory install with this URL formation.

http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/

I'm going to test the following formation next to see if I can reproduce it this way.

http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/
Owner

jaswrks commented Dec 24, 2013

When doing the same thing from the Dashboard on a Child Site under a sub-directory install, the entire cache is deleted, for all sites, including the parent site (unexpected behavior).

@raamdev I just tested the latest development copy (with all pull requests merged in) and I was unable to reproduce this on a sub-directory install (e.g. it's working as expected; clearing only the cache for the current blog you're on). I'm running a sub-directory install with this URL formation.

http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/

I'm going to test the following formation next to see if I can reproduce it this way.

http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/
@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 24, 2013

Owner

@raamdev I reproduced it under this directory structure. Taking a look now.

http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/
Owner

jaswrks commented Dec 24, 2013

@raamdev I reproduced it under this directory structure. Taking a look now.

http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/
@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 24, 2013

Owner

@raamdev Issue identified. I'll commit a fix shortly.

Owner

jaswrks commented Dec 24, 2013

@raamdev Issue identified. I'll commit a fix shortly.

@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 24, 2013

Owner

@raamdev These latest commits are now pending your approval in the existing pull requests for both Quick Cache and Quick Cache Pro. The two commits referenced above will correct the bug reported in this issue.

https://github.com/JasWSInc/Quick-Cache/commit/d2f9697b58242e9593cfac5cd0acd10bd178c8ab
https://github.com/JasWSInc/Quick-Cache-Pro/commit/98329d66063bfbbacfcd33af7fd5e637039502f0

How to confirm this bug is fixed.

  • Update to the latest dev version of Quick Cache Pro (with all pull requests merged in).
  • Save your Quick Cache Options once after this update. This forces Quick Cache to rebuild it's map of blog paths in /wp-content/cache/qc-blog-paths. Note: this step is only required during testing, this map is automatically rebuilt whenever a site owner updates to the latest version of Quick Cache or Quick Cache Pro (e.g. when the version changes).
  • Test on both of these URL formations please.
http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/
http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

I can confirm this now works as expected in all cases; e.g. for sub-domains, sub-directories, and also for nested sub-directories (at any depth).

Owner

jaswrks commented Dec 24, 2013

@raamdev These latest commits are now pending your approval in the existing pull requests for both Quick Cache and Quick Cache Pro. The two commits referenced above will correct the bug reported in this issue.

https://github.com/JasWSInc/Quick-Cache/commit/d2f9697b58242e9593cfac5cd0acd10bd178c8ab
https://github.com/JasWSInc/Quick-Cache-Pro/commit/98329d66063bfbbacfcd33af7fd5e637039502f0

How to confirm this bug is fixed.

  • Update to the latest dev version of Quick Cache Pro (with all pull requests merged in).
  • Save your Quick Cache Options once after this update. This forces Quick Cache to rebuild it's map of blog paths in /wp-content/cache/qc-blog-paths. Note: this step is only required during testing, this map is automatically rebuilt whenever a site owner updates to the latest version of Quick Cache or Quick Cache Pro (e.g. when the version changes).
  • Test on both of these URL formations please.
http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/
http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

I can confirm this now works as expected in all cases; e.g. for sub-domains, sub-directories, and also for nested sub-directories (at any depth).

@raamdev

This comment has been minimized.

Show comment Hide comment
@raamdev

raamdev Dec 24, 2013

Owner

Thank you, @jaswsinc. I have tested your commits against the following multisite environments and I can confirm clearing the cache now works as expected:

Sub-directories

http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/
http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

Sub-domains

http://www.example.com/
http://blog1.example.com/
http://blog2.example.com/
http://blog3..example.com/
Owner

raamdev commented Dec 24, 2013

Thank you, @jaswsinc. I have tested your commits against the following multisite environments and I can confirm clearing the cache now works as expected:

Sub-directories

http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/
http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

Sub-domains

http://www.example.com/
http://blog1.example.com/
http://blog2.example.com/
http://blog3..example.com/
@raamdev

This comment has been minimized.

Show comment Hide comment
@raamdev

raamdev Dec 25, 2013

Owner

This bug was fixed in Quick Cache v131224:

https://github.com/WebSharks/Quick-Cache/releases/tag/131224

Owner

raamdev commented Dec 25, 2013

This bug was fixed in Quick Cache v131224:

https://github.com/WebSharks/Quick-Cache/releases/tag/131224

@raamdev raamdev closed this Dec 25, 2013

@jaswrks

This comment has been minimized.

Show comment Hide comment
@jaswrks

jaswrks Dec 25, 2013

Owner

Awesome! Thanks for the merge.

Owner

jaswrks commented Dec 25, 2013

Awesome! Thanks for the merge.

@jaswrks jaswrks referenced this issue Dec 26, 2013

Closed

Feature Request: CDN #55

8 of 15 tasks complete
@her63

This comment has been minimized.

Show comment Hide comment
@her63

her63 Jan 30, 2014

I am herry , Admin of www.kristusrajaandalas.or.id could you tell me what is MD5 version salt and how to do it. thank u

her63 commented Jan 30, 2014

I am herry , Admin of www.kristusrajaandalas.or.id could you tell me what is MD5 version salt and how to do it. thank u

@raamdev

This comment has been minimized.

Show comment Hide comment
@raamdev

raamdev Feb 3, 2014

Owner

@her63 Please open a trouble ticket here: WebSharks Support Center

Owner

raamdev commented Feb 3, 2014

@her63 Please open a trouble ticket here: WebSharks Support Center

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment