New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pro Updater compatibility for ManageWP #465

Closed
raamdev opened this Issue Apr 10, 2015 · 12 comments

Comments

Projects
None yet
4 participants
@raamdev
Contributor

raamdev commented Apr 10, 2015

ManageWP allows site owners to manage multiple WordPress sites from a single Dashboard, which allows site owners to easily upgrade plugins on multiple sites at once. However, the ZenCache Pro Updater is not compatible with this, so site owners need to login to each site individually to perform the ZenCache Pro update.

There is a ManageWP API, which is essentially just a set of three hooks that we'll need to attach appropriate routines to, that allows premium plugin developers to add support for updating premium plugins outside WordPress.org:

  • mwp_premium_update_notification
  • mwp_premium_perform_update
  • mwp_premium_update_check

I reviewed the current ZenCache Pro updater functions and these will need some updating before we can just attach these hooks (i.e., the updater functions currently assume they're being run on the WordPress Dashboard and just output messages instead of returning specific values).

We can also search GitHub for other plugins that have integrated with ManageWP for more real-world examples.


Related: #395 #394 #465 #289 #464 #352

@patdumond

This comment has been minimized.

patdumond commented Feb 15, 2016

+1 for this feature: referencing internal private ticket https://websharks.zendesk.com/agent/tickets/11122.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Apr 22, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Apr 22, 2016

Noting that the ManageWP API page has been updated to include the following notice:

Important notice! This API is now deprecated and ManageWP now supports all premium plugins and themes that use standard WordPress update functionality to hook and display updates to in the WordPress admin out of the box. You do not need to do anything now, we are leaving this page for reference only.

So, since the ManageWP API is no longer supported, it looks like integrating with ManageWP will involve adapting our Pro Updater to work more closely with the WordPress update system. We already do this in some ways, but we could improve the integration so that any plugins, such as ManageWP, also work with our Pro Updater (and perhaps even with the Jetpack Site Management feature, which allows you to manage plugin updates for multiple self-hosted sites from a central WordPress.com account.

Right now the Comet Cache Pro Plugin Updater is used for both supplying the username/password and running the update. What I propose we look into is using the Pro Plugin Updater page only for configuring (and validating) the username/password, but have the actual update be triggered by WordPress through the Plugin page, so that when an update is available it appears the same way as any other WordPress plugin.

@raamdev

This comment has been minimized.

Contributor

raamdev commented May 23, 2016

@jaswsinc Any opposition to what I suggested in the last paragraph above?

@jaswrks

This comment has been minimized.

Member

jaswrks commented May 23, 2016

Nope. It sounds like a plan to me. I think all that really needs to happen is that this filter needs to be capable of working without relying on request variables, the current user, or transients. That way CC details are given whenever WordPress itself looks for available upgrades.

I recently discovered that we can also hook into the underlying WordPress.org API calls, as seen by example in the WPSC RV handler here.

See also: where the filter is established.

@raamdev raamdev referenced this issue May 23, 2016

Closed

Updating #778

@raamdev

This comment has been minimized.

Contributor

raamdev commented May 23, 2016

+1 here: #778

@bobo1

This comment has been minimized.

bobo1 commented Jul 12, 2016

Any progress on this? Getting to be a real pain to go to each supported website and update instead of using managewp and the standard WP upgrade tools.

@raamdev raamdev added this to the Next Release milestone Jul 12, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jul 12, 2016

@bobo1 I've added this to the Next Release milestone. We'll try to get this into the next release.

@jaswrks jaswrks self-assigned this Aug 24, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Aug 24, 2016

I'm assigning this to myself and I'll begin work on it shortly so that Raam can review a PR.

@jaswrks jaswrks referenced this issue Aug 24, 2016

Closed

PR: feature/465 #272

@raamdev

This comment has been minimized.

Contributor

raamdev commented Sep 1, 2016

Coming in the next release, support for ManageWP:

2016-09-01_00-34-50

Comet Cache Pro updates now utilize the built-in WordPress Plugin Updater system:

2016-09-02_17-03-06

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Sep 2, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Sep 2, 2016

Next Release Changelog:

  • ManageWP Compatibility (Pro): Comet Cache Pro is now compatible with ManageWP, a service that allows remote management of multiple WordPress sites. Comet Cache Pro Plugin Updates will now appear in the ManageWP dashboard and, assuming you have saved valid license credentials in Dashboard → Comet Cache Pro → Plugin Options → Update Credentials, you will be able to upgrade Comet Cache Pro remotely from the ManageWP Dashboard. Props @jaswsinc. See Issue #465.
  • Rewritten Pro Plugin Updater: The Comet Cache Pro Plugin Updater has been redesigned to use the built-in WordPress plugin updater system. When a Comet Cache Pro update is available, it now appears in the WordPress Updates section and in the Plugins list, like other WordPress plugins and can be updated normally like other WordPress plugins, as long as you have saved valid Comet Cache Pro license details in the new "Update Credentials" options panel. Props @jaswsinc. See Issue #272.

@raamdev raamdev closed this Sep 2, 2016

raamdev added a commit that referenced this issue Sep 17, 2016

Phing release of v160917 with the following changes:
- **New Feature** (Lite): The Clear Cache button is now available in the Admin Toolbar for the Lite version of Comet Cache.
- **New Feature** (Pro): Comet Cache Pro is now fully compatible with [WordPress Automatic Background Updates](https://codex.wordpress.org/Configuring_Automatic_Background_Updates#Plugin_.26_Theme_Updates_via_Filter). If you enable automatic background updates for plugins, and you save valid Comet Cache Pro License Credentials in the _Comet Cache Pro → Plugin Options → Update Credentials_ panel, you will automatically receive Pro plugin updates. Props @jaswsinc. See [Issue #289](#289).
- **Bug Fix**: In some scenarios Comet Cache might produce a false-positive "Warning: mkdir(): File exists" message when checking if the cache directory exists. Comet Cache now calls `clearstatcache()` and uses `file_exists()` instead of `is_dir()` to help make this check more robust. See [Issue #786](#786).
- **Bug Fix**: Fixed a bug where the Comet Cache PHP requirements check would fail and produce a fatal error when upgrading from a version of Comet Cache that did not require an extension that is now required by newer releases. This would occur when, for example, the required PHP `mbstring` extension was missing. Props @jaswsinc for finding the bug. See [Issue #817](#817).
- **Bug Fix**: Fixed a bug where upgrading from v160521 would result in the Client-Side Cache option being reset to the default (disabled). If you enabled the Client-Side Cache at some point, now is a good time to double-check that it's still enabled. This bug fix also improves the reliability of all version upgrade routines that Comet Cache runs during upgrades. See [Issue #807](#807).
- **Compatibility / Bug Fix**: The automatic Clear Cache routines that cleared the entire cache automatically whenever _WordPress Dashboard → Settings → General_ was updated, were being too aggressive and not taking into consideration other plugins that might also be using the same `options-general.php` URL. As a result, the entire cache was being unnecessarily cleared when the settings for those other plugins were saved. Props to @futtta from Autoptimize for reporting. See [Issue #825](#825).
- **UI Enhancement:** Adjusted option page font styles for WordPress v4.6 to better match existing style. See [Issue #271](websharks/comet-cache-pro#271).
- **ManageWP Compatibility** (Pro): Comet Cache Pro is now compatible with ManageWP, a service that allows remote management of multiple WordPress sites. Comet Cache Pro Plugin Updates will now appear in the ManageWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the ManageWP Dashboard. Props @jaswsinc. See [Issue #465](#465).
- **InfiniteWP Compatibility** (Pro): Comet Cache Pro is now compatible with InfiniteWP, an application that allows you to manage multiple WordPress sites from a single location. Comet Cache Pro Plugin Updates will now appear in the InfiniteWP dashboard and, assuming you have saved valid license credentials in _Dashboard → Comet Cache Pro → Plugin Options → Update Credentials_, you will be able to upgrade Comet Cache Pro remotely from the InfiniteWP Dashboard. See [Issue #394](#394).
- **Rewritten Pro Plugin Updater**: The Comet Cache Pro Plugin Updater has been redesigned to use the built-in WordPress plugin updater system. When a Comet Cache Pro update is available, it now appears in the WordPress Updates section and in the Plugins list, like other WordPress plugins and can be updated normally like other WordPress plugins, as long as you have saved valid Comet Cache Pro license details in the new "Update Credentials" options panel. Props @jaswsinc. See [Issue #272](websharks/comet-cache-pro#272).
- **Code Style**: The `WP_CACHE` line that gets inserted into the `wp-config.php` file to enable caching now follows the [WordPress PHP Code Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/). Props @szepeviktor. See [Issue #799](#799).
- **Compatibility** (Pro): When the Autoptimize plugin is active, the Comet Cache Pro HTML Compressor panel now shows a friendly notice explaining that both the HTML Compressor and Autoptimize should not be enabled at the same time because they both address the same performance improvements. The rest of Comet Cache works great alongside Autoptimize and whether you use the HTML Compressor or Autoptimize is a matter of preference. Props to @futtta from Autoptimize for the continued collaboration.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Sep 17, 2016

Comet Cache v160917 has been released and includes changes from this GitHub Issue. See the v160917 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#465).

@websharks websharks locked and limited conversation to collaborators Sep 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.