New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivating plugin via WP-CLI yields errors #728

Closed
MarioKnight opened this Issue Mar 30, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@MarioKnight

MarioKnight commented Mar 30, 2016

This seems to match #563 from what I can see. In trying to determine an error (confirmed now to not have been caused by Comet Cache), I attempted to disable Comet Cache Pro through the command line and received the following errors:

Fatal error: Uncaught exception 'Exception' with message 'Invalid argument; host token empty!' in /xxxxx/wp-content/plugins/comet-cache-pro/src/includes/closures/Shared/CacheDirUtils.php:274
Stack trace:
#0 [internal function]: WebSharks\CometCache\Pro\AbsBaseAp->WebSharks\CometCache\Pro\{closure}('/^.+/i')
#1 /xxxxx/wp-content/plugins/comet-cache-pro/src/includes/classes/AbsBaseAp.php(55): call_user_func_array(Object(Closure), Array)
#2 /xxxxx/wp-content/plugins/comet-cache-pro/src/includes/closures/Shared/CacheDirUtils.php(54): WebSharks\CometCache\Pro\AbsBaseAp->__call('deleteFilesFrom...', Array)
#3 /xxxxx/wp-content/plugins/comet-cache-pro/src/includes/closures/Shared/CacheDirUtils.php(54): WebSharks\CometCache\Pro\Plugin->deleteFilesFromHostCacheDir('/^.+/i')
#4 [internal function]: WebSharks\CometCache\Pro\AbsBaseAp->WebSharks\CometCache\Pro\{closure}('/^.+/i')
#5 /xxxxx/wp-content/plugins/comet-cache-pro/src/include in /xxxxx/wp-content/plugins/comet-cache-pro/src/includes/closures/Shared/CacheDirUtils.php on line 274

I don't think is something that would be done often (I only did it this way since I didn't want to login to WordPress if I didn't have to), but I figured y'all would want to know. Please let me know if you need anything else from my end.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Apr 4, 2016

Thanks for the report, @MarioKnight. It sounds like this is related to #464

@raamdev

This comment has been minimized.

Contributor

raamdev commented Apr 9, 2016

Noting that adding --url= to the WP-CLI command and specifying your WordPress Site Address allows Comet Cache to be disabled properly without the "host token empty" error.

  --url=<url>
      Pretend request came from given URL. In multisite, this argument is how the target
  site is specified.
@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 9, 2016

Referencing the following areas of the CC codebase where we could try to use a default value matching the current site's host name; i.,e, parse_url(home_url('/'), PHP_URL_HOST) (or similar).

The same would be true in the case of $_SERVER['REQUEST_URI'], which could default to just /.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Apr 10, 2016

@jaswsinc I assume you're suggesting that we apply those defaults only if (defined('WP_CLI') && WP_CLI && empty($_SERVER['HTTP_HOST'])), correct?

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 10, 2016

@raamdev Yes, correct. Maybe it would help if we create a new method somewhere in the Shared Traits folder called envVar() that would capable of returning $_SERVER environment variables from a central location. That method could be responsible for working out a default value whenever we can detect (in this case) that WP CLI is running without them, which leads to this problem.

Doing it that way would also allow us to read the information we need from those variables without contaminating the global environment at large; i.e., without writing to $_SERVER directly, which may have an undesirable impact on plugins that do not expect them to exist in CLI processes.

@raamdev raamdev added this to the Future Release milestone Apr 10, 2016

@raamdev raamdev modified the milestones: Next Release, Future Release May 11, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented May 12, 2016

Next Actions

  • Change this line to the following:

    $token = !empty($_SERVER['HTTP_HOST']) ? (string) $_SERVER['HTTP_HOST'] : '';
  • Same thing on this line.

  • Same thing on this line.

  • Replace this line with the following:

    if (empty($_SERVER['HTTP_HOST']) || empty($_SERVER['REQUEST_URI'])) {
        return ''; // Not possible.
    }
    return ($this->isSsl() ? 'https://' : 'http://').$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI'];
  • Change this line to the following:

    if (!empty($home) && 0 !== strcasecmp($home, $siteurl) && !empty($_SERVER['SCRIPT_FILENAME'])) {
  • Change this line to the following:

    } elseif (COMET_CACHE_EXCLUDE_CLIENT_SIDE_URIS && (empty($_SERVER['REQUEST_URI']) || preg_match(COMET_CACHE_EXCLUDE_CLIENT_SIDE_URIS, $_SERVER['REQUEST_URI']))) {
  • Change this line to the following:

    if ($_notice['only_on_uris'] && (empty($_SERVER['REQUEST_URI']) || !@preg_match($_notice['only_on_uris'], $_SERVER['REQUEST_URI']))) {
  • Submit PR for review.

@jaswrks jaswrks added the outlined label May 12, 2016

renzms added a commit to websharks/comet-cache-pro that referenced this issue May 25, 2016

renzms added a commit to websharks/comet-cache-pro that referenced this issue May 26, 2016

renzms added a commit to websharks/comet-cache-pro that referenced this issue Jun 2, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jun 3, 2016

Next Release Changelog:

  • WP-CLI Compatibility: Fixed a bug with deactivating Comet Cache using WP-CLI. Doing so was producing a "Invalid argument; host token empty!" error message. This has been resolved. Props @MarioKnight @jaswsinc @renzms. See Issue #728.

@raamdev raamdev closed this Jun 3, 2016

raamdev added a commit that referenced this issue Jul 7, 2016

Phing release of v160706 with the following changes:
- **New Feature! Apache Optimizations.** This release includes a completely new option panel for Apache Performance Tuning. Current options for Apache tuning include GZIP Compression, Leverage Browser Caching, Enforce Canonical URLs, and Send Access-Control-Allow-Origin Header (for Static CDN Filters). These options automatically add or remove from your `.htaccess` file the appropriate configuration based on the options you enable or disable (all options are disabled by default, so your `.htaccess` file is not modified unless you say so). If you prefer to update your `.htaccess` file manually, the necessary configuration can be viewed beneath each option. Props @jaswsinc, @renzms. See [Issue #789](#789).
- **New Feature!** A new "Enable GZIP Compression" option has been added to the new Apache Optimizations panel. This option will automatically add the appropriate configuration to your `.htaccess` file to enable GZIP compression. This option is disabled by default. The old "GZIP Compression" panel has been removed in favor of the new option inside Apache Optimizations. Props @renzms, @jaswsinc. See [Issue #764](#764).
- **New Feature!** Multisite Host Exclusion Patterns. It's now possible to exclude entire sites from the cache in a Multisite Network environment. Domain mapping is also supported! See _Comet Cache → Plugin Options → Host Exclusion Patterns_. If you're running a Multisite Network with Sub-Directories, you can exclude sites using the existing URI Exclusion Patterns feature. Props @kristineds. See [Issue #754](#754).
- **New Feature (Pro)!** A new "Leverage Browser Caching" option has been added to the new Apache Optimizations panel. This option will automatically add the appropriate configuration to your `.htaccess` file to enable Browser Caching. This option is disabled by default. Props @renzms, @jaswsinc. See [Issue #764](#764).
- **New Feature (Pro)!** A new "Enforce Canonical URLs" option has been added to the new Apache Optimizations panel. This options adds the appropriate `.htaccess` code to enforce the correct canonical URLs according to your WordPress Permalink settings (Comet Cache detects if the Permalink Structure ends with a trailing slash, or without a trailing slash). Props @renzms, @jaswsinc. See [Issue #554](#554).
- **Bug Fix**: In some scenarios the Cron Event that cleans up expired cache files (`_cron_comet_cache_cleanup`) would never run, or the Next Run time would constantly reset to 1 minute away from running every time a page was reloaded. We suspect this is a race condition and in attempt to work around this issue we now skip all of our Cron-related checks if Cron is currently in the middle of running a process. Props @xberg and @lkraav for help reporting. See [Issue #653](#653).
- **Bug Fix**: If your site uses aliased domains, Comet Cache now properly considers all possible domain variations when it clears the cache on WP Standard installations. Props @kristineds, @jaswsinc, @yoffe, and @VR51. See [Issue #608](#608).
- **Bug Fix** (Pro): Fixed a bug where Comet Cache would appear to prevent WordPress from redirecting Permalinks that don't include a trailing slash, to the URL that does include a trailing slash. This was due to the fact that Comet Cache loads very early on (for caching purposes) and as a result the WordPress `redirect_canonical()` function never gets run. This was fixed by adding an option to the new Apache Optimizations panel that allows you to Enforce Canonical URLs. Props @renzms, @jaswsinc. See [Issue #554](#554).
- **UX Bug Fix** (Pro): If you had your WordPress Dashboard login details saved by your browser, the browser autofill would automatically fill in the Pro Plugin Updater fields with those details, which then needed to be replaced with your actual Pro license details. The browser autofill has been disabled for those fields (tested in Chrome, Firefox, and Safari). Props @renzms. See [Issue #741](#741).
- **Enhancement**: Added links the Options Page for the Comet Cache [Twitter](http://twitter.com/cometcache) and [Facebook](http://facebook.com/cometcache) accounts. Props @renzms. [Issue #771](#771).
- **Enhancement:** Added full support for UTF-8 (multibyte strings). This release adds full support for UTF-8 throughout the Comet Cache codebase, greatly enhancing Comet Cache's ability to deal with file paths and URLs that may contain UTF-8 characters. Props @jaswsinc. [Issue #703](#703).
- **UI Enhancements**: Improved the Logged-In Users and the Client-Side Caching options panels to dim additional options when the feature is disabled. Additionally, the "Enable HTML Compression for Logged-In Users?" option has been relocated from the HTML Compressor option panel to the more appropriate Logged-In Users option panel. See [Issue #768](#768).
- **UX Enhancement**: Improved the inline docs for Auto-Clear List of Custom URLs to clarify that full URLs must be provided. Props @renzms. See [Issue #781](#781).
- **Enhancement** (Pro): The Pro Plugin Updater has been improved to allow for better compatibility with hosting platforms that use Apache's ModSecurity. In some cases, site owners were seeing a 404 error when attempting to update the Pro version using the Pro Plugin updater because certain ModSecurity rules were blocking the Pro Updater requests. The Pro Plugin Updater now uses WP Transients to store the necessary metadata, which works around the issue with ModSecurity. Props to @seozones for reporting and @jaswsinc for help fixing this. [Issue #416](#416).
- **Enhancement** (Pro): When Static CDN Filters are enabled, it's now possible to disable the automatic insertion of rules into your `.htaccess` file that are designed to prevent issues with [CORS](https://cometcache.com/kb-article/what-are-cross-origin-request-blocked-errors/). See _Apache Optimizations → Send Access-Control-Allow-Origin Header?_ See [Issue #787](#787).
- **Enhancement** (Pro): The HTML Notes added to the bottom of a cached page now specify if the page was cached as the result of an HTTP Request or if it was cached by the Auto-Cache Engine. Props @kristineds. See [Issue #292](#292).
- **Enhancement** (Pro): The Auto-Cache Engine now supports a fallback to cURL using the WP HTTP API. If your PHP configuration has `allow_fopen_url=0`, the Auto-Cache Engine will use the fallback to download the XML Sitemap and parse it from a temporary file. If you want to force the use of this fallback even when `allow_fopen_url=1`, you can use [a filter](#440 (comment)). See [Issue #440](#440).
- **UI Enhancement** (Pro): A second button has been added to the bottom of the Pro Plugin Updater page that allows you to "Save and Update Comet Cache Pro" in one step. Props @renzms. See [Issue #741](#741).
- **UI Enhancement** (Pro): The "Cache Stats" button in Admin Bar is now linked to the Cache Stats page. Instead of hovering over the button and then clicking "More Info" inside the popup panel, you can now just click the "Cache Stats" button to go directly to the Cache Stats page. Props @Presskopp, @renzms. See [Issue #780](#780).
- **Comment Mail Compatibility:** Improved compatibility with the Comment Mail plugin by automatically clearing the cache whenever Comment Mail options are changed. Many of the Comment Mail options affect front-end portions of the site, so it's important that the cache is cleared whenever Comment Mail options change. See [Comment Mail Issue #278](websharks/comment-mail#278 (comment)).
- **PHP Compatibility:** Improved compatibility back to PHP 5.2 (the lowest version allowed by WordPress). Comet Cache still requires PHP 5.4+, but if you install Comet Cache on a site running PHP 5.2, it will now fail gracefully with a Dashboard notice indicating PHP 5.4+ is required, instead of producing a fatal error. See [Issue #784](#784).
- **WP-CLI Compatibility**: Fixed a bug with deactivating Comet Cache using WP-CLI. Doing so was producing a "Invalid argument; host token empty!" error message. This has been resolved. Props @MarioKnight @jaswsinc @renzms. See [Issue #728](#728).
- Renamed `COMET_CACHE_ALLOW_BROWSER_CACHE` constant to `COMET_CACHE_ALLOW_CLIENT_SIDE_CACHE`. Backwards compatibility has been maintained.
- Renamed `allow_browser_cache` plugin option to `allow_client_side_cache`.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Jul 7, 2016

Comet Cache v160706 has been released and includes changes from this GitHub Issue. See the v160706 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#728).

@websharks websharks locked and limited conversation to collaborators Jul 7, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.