New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Second Pro Updater Button #741

Closed
jaswrks opened this Issue Apr 19, 2016 · 15 comments

Comments

Projects
None yet
3 participants
@jaswrks
Member

jaswrks commented Apr 19, 2016

In the latest release whenever I fill-in my Username and License Key, then scroll to the bottom, all I find is the "Save All Changes" button. Clicking that does what it says, but it's not quite clear how I can actually perform the upgrade itself.

2016-04-18_21-03-28


Of course, there is another button at the top that allows me to begin the upgrade, but that seems slightly confusing, because that button is not presented in the same context as my Username/License Key is, which is what I need to enter to complete the upgrade.

Keep in mind that Comet Cache Pro suggests (through a notice) that a site owner visit this page whenever a new version becomes available. After clicking that link in the notice, my expectation (after clicking the link to complete an upgrade), is that this page will allow me to do the upgrade, not just save upgrade-related options.

I suggest that we add a second button (at the bottom) with the label: Save All & Upgrade Now. Clicking that would perform two actions:

  • Save the options.
  • Perform the upgrade.

@jaswrks jaswrks added the enhancement label Apr 19, 2016

@raamdev

This comment has been minimized.

Member

raamdev commented Apr 20, 2016

I agree it's a problem that needs solving, but I'm not sure yet about the best way to go about solving it from a UX perspective.

Following are two mockups of a second button at the bottom—both feel slightly wrong to me from a usability perspective (it's confusing: do I Save and Then Update? Or does Update also Save?):

2016-04-19_20-33-11
2016-04-19_20-33-44

One thing that might work is to change the "Update Comet Cache Now" to "Save and Update Comet Cache Now" so that it's clear you can do both with one button:

2016-04-19_20-37-48

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 20, 2016

One thing that might work is to change the "Update Comet Cache Now" to "Save and Update Comet Cache Now" so that it's clear you can do both with one button:

Cool. That sounds good to me also. I like the "Save and Update" idea. That does make it clearer.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Apr 20, 2016

While working on this issue, it would be awesome if we could find a way to disable Google Chrome Auto-Fill on this page (notice the yellow fields in my screenshot above). That always seems to get in my way on this page. That's not a CC problem, it's a Chrome problem, but if there is a way to turn that off altogether I'd love to know how.

I have never been able to accomplish this myself in any reliable way, so maybe it is just not possible to do it. I just thought I would mention it in case anyone else becomes aware of some way to turn that off for specific forms or specific fields.

@raamdev raamdev added this to the Next Release milestone Apr 21, 2016

@raamdev raamdev modified the milestones: Next Release, Future Release May 11, 2016

@raamdev

This comment has been minimized.

Member

raamdev commented Jun 1, 2016

What needs to be done

We need to add a second button to the bottom of the Plugin Updater page, one that goes right next to the "Save All Changes" button and says "Save and Update Comet Cache" (note: the screenshot says "Save and Update Comet Cache Now", but I feel we should take out the "Now").

2016-04-19_20-37-48

Right now we have a "Save All Changes" button at the bottom and an "Update Comet Cache Now" button at the top right of the page, but a site owner might scroll to the bottom of the page and expect to see a way to "save and update".

The "Update Comet Cache Now" button in the top right actually does a save and update, so this new "Save and Update Comet Cache" button should behave the exact same way. The only new thing here is that we're providing two buttons for saving and updating: One at the top right that says "Update Comet Cache Now" and one at the bottom that says "Save and Update Comet Cache".

@raamdev

This comment has been minimized.

Member

raamdev commented Jun 1, 2016

@jaswsinc writes...

it would be awesome if we could find a way to disable Google Chrome Auto-Fill on this page

It seems this is the only workaround (even as recently as March 2016): http://stackoverflow.com/a/15917221/130664 I'm not sure how I feel about adding hidden fields to the page to solve this, but if you think it's worth doing, I'm fine with it.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jun 1, 2016

Nah, I'm not wild about that idea either.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jun 1, 2016

@raamdev

This comment has been minimized.

Member

raamdev commented Jun 1, 2016

@jaswsinc writes...

Did you give this a go?
http://stackoverflow.com/a/30976223/1219741

Whoa! I just tried that and it worked! Sweet.

Now I wonder if that's cross-browser compatible though... will Firefox obey autocomplete="new-password"?

@raamdev

This comment has been minimized.

Member

raamdev commented Jun 1, 2016

Nope, autocomplete="new-password" is not compatible with Firefox—when you use new-password, Firefox ends up auto-filling the fields.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jun 1, 2016

Whoa! I just tried that and it worked! Sweet.

Ah. Awesome! Well, at least Chrome can be made to obey. That's progress!

@raamdev

This comment has been minimized.

Member

raamdev commented Jun 1, 2016

It looks like we can use autocomplete="off" in the <form> tag and Firefox will obey that. Then we can use autocomplete="new-password" in the individual fields, and Chrome will obey that. Woohoo!

@renzms Please include the above changes in your PR for this issue. :-)

@raamdev

This comment has been minimized.

Member

raamdev commented Jun 10, 2016

Next Release Changelog:

  • UX Bug Fix (Pro): If you had your WordPress Dashboard login details saved by your browser, the browser autofill would automatically fill in the Pro Plugin Updater fields with those details, which then needed to be replaced with your actual Pro license details. The browser autofill has been disabled for those fields (tested in Chrome, Firefox, and Safari). Props @renzms. See Issue #741.
  • UI Enhancement (Pro): A second button has been added to the bottom of the Pro Plugin Updater page that allows you to "Save and Update Comet Cache Pro" in one step. Props @renzms. See Issue #741.

@raamdev raamdev closed this Jun 10, 2016

@raamdev raamdev reopened this Jun 16, 2016

@raamdev

This comment has been minimized.

Member

raamdev commented Jun 16, 2016

@renzms The Save All Changes button should not be half-width on the Plugin Options or Stats/Charts pages, only the Plugin Updater page:

2016-06-15_22-39-33

@renzms

This comment has been minimized.

renzms commented Jun 16, 2016

The Save All Changes button should not be half-width on the Plugin Options or Stats/Charts pages, only the Plugin Updater page:

@raamdev Thanks for catching that, I'll make a new class for the buttons on the Plugin Updater page, so it only affects that page.

renzms added a commit to websharks/comet-cache-pro that referenced this issue Jun 17, 2016

@raamdev raamdev closed this Jun 17, 2016

raamdev added a commit that referenced this issue Jul 7, 2016

Phing release of v160706 with the following changes:
- **New Feature! Apache Optimizations.** This release includes a completely new option panel for Apache Performance Tuning. Current options for Apache tuning include GZIP Compression, Leverage Browser Caching, Enforce Canonical URLs, and Send Access-Control-Allow-Origin Header (for Static CDN Filters). These options automatically add or remove from your `.htaccess` file the appropriate configuration based on the options you enable or disable (all options are disabled by default, so your `.htaccess` file is not modified unless you say so). If you prefer to update your `.htaccess` file manually, the necessary configuration can be viewed beneath each option. Props @jaswsinc, @renzms. See [Issue #789](#789).
- **New Feature!** A new "Enable GZIP Compression" option has been added to the new Apache Optimizations panel. This option will automatically add the appropriate configuration to your `.htaccess` file to enable GZIP compression. This option is disabled by default. The old "GZIP Compression" panel has been removed in favor of the new option inside Apache Optimizations. Props @renzms, @jaswsinc. See [Issue #764](#764).
- **New Feature!** Multisite Host Exclusion Patterns. It's now possible to exclude entire sites from the cache in a Multisite Network environment. Domain mapping is also supported! See _Comet Cache → Plugin Options → Host Exclusion Patterns_. If you're running a Multisite Network with Sub-Directories, you can exclude sites using the existing URI Exclusion Patterns feature. Props @kristineds. See [Issue #754](#754).
- **New Feature (Pro)!** A new "Leverage Browser Caching" option has been added to the new Apache Optimizations panel. This option will automatically add the appropriate configuration to your `.htaccess` file to enable Browser Caching. This option is disabled by default. Props @renzms, @jaswsinc. See [Issue #764](#764).
- **New Feature (Pro)!** A new "Enforce Canonical URLs" option has been added to the new Apache Optimizations panel. This options adds the appropriate `.htaccess` code to enforce the correct canonical URLs according to your WordPress Permalink settings (Comet Cache detects if the Permalink Structure ends with a trailing slash, or without a trailing slash). Props @renzms, @jaswsinc. See [Issue #554](#554).
- **Bug Fix**: In some scenarios the Cron Event that cleans up expired cache files (`_cron_comet_cache_cleanup`) would never run, or the Next Run time would constantly reset to 1 minute away from running every time a page was reloaded. We suspect this is a race condition and in attempt to work around this issue we now skip all of our Cron-related checks if Cron is currently in the middle of running a process. Props @xberg and @lkraav for help reporting. See [Issue #653](#653).
- **Bug Fix**: If your site uses aliased domains, Comet Cache now properly considers all possible domain variations when it clears the cache on WP Standard installations. Props @kristineds, @jaswsinc, @yoffe, and @VR51. See [Issue #608](#608).
- **Bug Fix** (Pro): Fixed a bug where Comet Cache would appear to prevent WordPress from redirecting Permalinks that don't include a trailing slash, to the URL that does include a trailing slash. This was due to the fact that Comet Cache loads very early on (for caching purposes) and as a result the WordPress `redirect_canonical()` function never gets run. This was fixed by adding an option to the new Apache Optimizations panel that allows you to Enforce Canonical URLs. Props @renzms, @jaswsinc. See [Issue #554](#554).
- **UX Bug Fix** (Pro): If you had your WordPress Dashboard login details saved by your browser, the browser autofill would automatically fill in the Pro Plugin Updater fields with those details, which then needed to be replaced with your actual Pro license details. The browser autofill has been disabled for those fields (tested in Chrome, Firefox, and Safari). Props @renzms. See [Issue #741](#741).
- **Enhancement**: Added links the Options Page for the Comet Cache [Twitter](http://twitter.com/cometcache) and [Facebook](http://facebook.com/cometcache) accounts. Props @renzms. [Issue #771](#771).
- **Enhancement:** Added full support for UTF-8 (multibyte strings). This release adds full support for UTF-8 throughout the Comet Cache codebase, greatly enhancing Comet Cache's ability to deal with file paths and URLs that may contain UTF-8 characters. Props @jaswsinc. [Issue #703](#703).
- **UI Enhancements**: Improved the Logged-In Users and the Client-Side Caching options panels to dim additional options when the feature is disabled. Additionally, the "Enable HTML Compression for Logged-In Users?" option has been relocated from the HTML Compressor option panel to the more appropriate Logged-In Users option panel. See [Issue #768](#768).
- **UX Enhancement**: Improved the inline docs for Auto-Clear List of Custom URLs to clarify that full URLs must be provided. Props @renzms. See [Issue #781](#781).
- **Enhancement** (Pro): The Pro Plugin Updater has been improved to allow for better compatibility with hosting platforms that use Apache's ModSecurity. In some cases, site owners were seeing a 404 error when attempting to update the Pro version using the Pro Plugin updater because certain ModSecurity rules were blocking the Pro Updater requests. The Pro Plugin Updater now uses WP Transients to store the necessary metadata, which works around the issue with ModSecurity. Props to @seozones for reporting and @jaswsinc for help fixing this. [Issue #416](#416).
- **Enhancement** (Pro): When Static CDN Filters are enabled, it's now possible to disable the automatic insertion of rules into your `.htaccess` file that are designed to prevent issues with [CORS](https://cometcache.com/kb-article/what-are-cross-origin-request-blocked-errors/). See _Apache Optimizations → Send Access-Control-Allow-Origin Header?_ See [Issue #787](#787).
- **Enhancement** (Pro): The HTML Notes added to the bottom of a cached page now specify if the page was cached as the result of an HTTP Request or if it was cached by the Auto-Cache Engine. Props @kristineds. See [Issue #292](#292).
- **Enhancement** (Pro): The Auto-Cache Engine now supports a fallback to cURL using the WP HTTP API. If your PHP configuration has `allow_fopen_url=0`, the Auto-Cache Engine will use the fallback to download the XML Sitemap and parse it from a temporary file. If you want to force the use of this fallback even when `allow_fopen_url=1`, you can use [a filter](#440 (comment)). See [Issue #440](#440).
- **UI Enhancement** (Pro): A second button has been added to the bottom of the Pro Plugin Updater page that allows you to "Save and Update Comet Cache Pro" in one step. Props @renzms. See [Issue #741](#741).
- **UI Enhancement** (Pro): The "Cache Stats" button in Admin Bar is now linked to the Cache Stats page. Instead of hovering over the button and then clicking "More Info" inside the popup panel, you can now just click the "Cache Stats" button to go directly to the Cache Stats page. Props @Presskopp, @renzms. See [Issue #780](#780).
- **Comment Mail Compatibility:** Improved compatibility with the Comment Mail plugin by automatically clearing the cache whenever Comment Mail options are changed. Many of the Comment Mail options affect front-end portions of the site, so it's important that the cache is cleared whenever Comment Mail options change. See [Comment Mail Issue #278](websharks/comment-mail#278 (comment)).
- **PHP Compatibility:** Improved compatibility back to PHP 5.2 (the lowest version allowed by WordPress). Comet Cache still requires PHP 5.4+, but if you install Comet Cache on a site running PHP 5.2, it will now fail gracefully with a Dashboard notice indicating PHP 5.4+ is required, instead of producing a fatal error. See [Issue #784](#784).
- **WP-CLI Compatibility**: Fixed a bug with deactivating Comet Cache using WP-CLI. Doing so was producing a "Invalid argument; host token empty!" error message. This has been resolved. Props @MarioKnight @jaswsinc @renzms. See [Issue #728](#728).
- Renamed `COMET_CACHE_ALLOW_BROWSER_CACHE` constant to `COMET_CACHE_ALLOW_CLIENT_SIDE_CACHE`. Backwards compatibility has been maintained.
- Renamed `allow_browser_cache` plugin option to `allow_client_side_cache`.
@raamdev

This comment has been minimized.

Member

raamdev commented Jul 7, 2016

Comet Cache v160706 has been released and includes changes from this GitHub Issue. See the v160706 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#741).

@websharks websharks locked and limited conversation to collaborators Jul 7, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.