Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Split/paginated comments pages aren't purged #75

Closed
bridgeport opened this Issue Feb 17, 2014 · 3 comments

Comments

Projects
None yet
2 participants

WordPress' Discussion settings has the following option:
Break comments into pages with [#] top level comments per page and the [last|first] page displayed by default

When this is activated and blog post comments are split across pages, Quick Cache does not purge anything beyond page 1. This is problematic because if a new comment is posted or old comment is deleted, all the comments across pages must shift one spot backward or forwards. As it stands, this only occurs on page 1.

Thanks.

I'm trying to see if this could be resolved by hooking into the 'ac-plugins' architecture, but I'm not sure if I'm on the right path. Could you provide a bit more detail about how to use the 'ac-plugins' architecture?

For instance, let's say I wanted to add my own ac-plugin action that'll be activated during a WordPress 'edit_comment' action? How would I hook into that and retrieve certain properties such as the page ID?

Thanks.

Owner

raamdev commented Feb 25, 2014

@bridgeport I've confirmed this unexpected behavior. With the current way that cache files are generated and stored on disk, fixing this issue isn't going to be quite as straightforward as I'd hoped. Creating an ac-plugin to clear the paginated comment page cache files is also not straightforward, as we run into the same issue with the way the cache files are currently being generated.

However, since I'm currently working on implementing a new cache structure, I'll simply wait until that's done, as that will resolve this issue.

Temporary workaround

In the meantime, I recommend excluding paginated comment pages using the URI Exclusion Patterns feature (Dashboard → Quick Cache → Plugin Options → URI Exclusion Patterns).

To exclude all paginated comment pages, you can add the following to the URI Exclusion Patterns:

*/comment-page-*/

The above exclusion pattern will exclude all paginated comment pages on all posts from being cached.

@raamdev raamdev added this to the Next release milestone Apr 18, 2014

Owner

raamdev commented Apr 18, 2014

@bridgeport This has been fixed by the new branched cache structure (#3) coming with the next release. Thank you for your patience.

@raamdev raamdev closed this Apr 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment