Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve Logged-In Users panel #768
When Logged-In Users caching is disabled (the default), everything else in that panel (other than the option to enable Logged-In Users caching) should be greyed out, as none of the other options are applicable unless Logged-In Users caching is enabled. (This should work the same way the HTML Compressor panel works.)
While we're at it, the Enable HTML Compression for Logged-In Users? option from the HTML Compressor panel should be moved to the Logged-In Users panel, as it seems more appropriate there.
Noting that this is complicated by the
So, we'll either need to change the
Working Around This Issue
@jaswsinc Thanks! :-)
You have a couple of bugs in that outline:
So, do you suggest adding a second line that attaches
referenced this issue
May 17, 2016
Copy. I missed that, sorry :-)
We could alter the select so that it includes an explicit attempt to include the enable/disable functionality on a given
$('select[name$="_enable\\]"], select[data-toggle~="enable-disable"]', plugin.$menuPage).not('.-no-if-enabled').on('change', plugin.enableDisable).trigger('change');
and then on the
echo ' <p><select name="'.esc_attr(GLOBAL_NS).'[saveOptions][when_logged_in]" data-toggle="enable-disable" data-enabled-strings="1,postload">'."\n";
added a commit
Jun 3, 2016
Next Release Changelog:
Comet Cache v160706 has been released and includes changes from this GitHub Issue. See the v160706 announcement for further details.
This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#768).