New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pro Preview Option Panel labels are not translatable #808

Closed
raamdev opened this Issue Jul 16, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@raamdev
Member

raamdev commented Jul 16, 2016

The "Pro Version Only" and "Additional Pro Features" labels that get added to option panels when the Pro Preview is enabled are not translatable:

cc-preview

That's because those labels are set via CSS:

We need to move those into MenuPageOptions.php so that they can be translated.


Reported by @Presskopp.

@raamdev raamdev added this to the Next Release milestone Jul 16, 2016

@raamdev raamdev modified the milestones: Next Release, Future Release Sep 6, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Oct 11, 2016

Estimate at .5 days.

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Nov 8, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 8, 2016

Next Release Changelog:

  • i18n Compat. This release makes all pro preview labels translatable by moving the labels that were previously defined in CSS only into HTML attribute values. See issue #808 if you'd like additional details.
@renzms

This comment has been minimized.

renzms commented Nov 16, 2016

@raamdev

Confirmed Working

The HTML values can now be translated/modified for the Pro Preview Option panels

screen shot 2016-11-16 at 11 42 11 pm

@raamdev

This comment has been minimized.

Member

raamdev commented Nov 19, 2016

Comet Cache v161119 has been released and includes changes from this GitHub Issue. See the v161119 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#808).

@raamdev raamdev closed this Nov 19, 2016

@websharks websharks locked and limited conversation to collaborators Nov 19, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.