New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart.js should not be enqueued in Lite version #830

Closed
raamdev opened this Issue Sep 19, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@raamdev
Contributor

raamdev commented Sep 19, 2016

In Comet Cache v160917 we included the Clear Cache button in the Admin Toolbar for the Lite version of Comet Cache (previously this was a Pro-only feature). As part of that work, the Chart.js was unnecessarily allowed to be included in the Lite verison here and here — this is unncessary as Chart.js is only used by the Comet Cache Stats/Charts feature (still a Pro-only feature).

We should avoid enqueueing Chart.js in the Lite version not only because it's not being used but because it can cause problems with other plugins that might be using a different version of Chart.js, as seen in the report below.

Pär Thernström, plugin author for the Simple History plugin (30k+ active installs) says:

Comet Cache uses an older version of the chart.js-library and there is a conflict because of the newer version included in Simple History. This will be fixed in the next version by putting the script used by Simple History in its own namespace.

Note that this has also been cross-referenced on the Comet Cache support forum.

@raamdev raamdev added lite todo labels Sep 19, 2016

@raamdev raamdev added this to the Next Release milestone Sep 19, 2016

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Nov 8, 2016

jaswsinc
- **Bug Fix:** Don't enqueue Chart.js unnecessarily in lite version o…
…f the sofware. See also: [issue #830](websharks/comet-cache#830) if you'd like additional details.
@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 8, 2016

Next Release Changelog:

  • Bug Fix: Don't enqueue Chart.js unnecessarily in lite version of the sofware. See also: issue #830 if you'd like additional details.
@renzms

This comment has been minimized.

renzms commented Nov 16, 2016

@raamdev

Confirmed Working

Chart.js only loaded in the Pro version. 👍

PRO:

screen shot 2016-11-16 at 11 13 40 pm

LITE:

screen shot 2016-11-16 at 11 13 28 pm

@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 19, 2016

Comet Cache v161119 has been released and includes changes from this GitHub Issue. See the v161119 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#830).

@raamdev raamdev closed this Nov 19, 2016

@websharks websharks locked and limited conversation to collaborators Nov 19, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.