New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Firefox = Broken Textarea #866

Closed
jaswrks opened this Issue Dec 28, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@jaswrks
Member

jaswrks commented Dec 28, 2016

  • Enable Static CDN Filters
  • Attempt to fill-in multiple CDN Hostnames from a Network installation.
  • Try to break down to the next line by pressing Enter.

This is broken in the most recent version of Firefox.

2016-12-28_03-14-48

@jaswrks jaswrks added the bug label Dec 28, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 28, 2016

@raamdev

This comment has been minimized.

Member

raamdev commented Dec 28, 2016

This appears to be caused by the style="white-space:nowrap;" attribute on that textarea.

@raamdev

This comment has been minimized.

Member

raamdev commented Dec 28, 2016

Related Mozilla bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1137650

According to the spec, we should be using style="white-space:pre-wrap;", which preserves new lines, not nowrap, which collapses new lines.

@raamdev

This comment has been minimized.

Member

raamdev commented Dec 28, 2016

Confirmed that pre-wrap works as expected on Firefox Version 50.1.0 (macOS), Chrome Version 55.0.2883.95 (macOS), and Safari Version 10.0.2 (macOS).

@raamdev raamdev added this to the Next Release milestone Dec 28, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 27, 2017

Referencing: https://developer.mozilla.org/en-US/docs/Web/CSS/white-space
~ I agree with the above and that was my mistake. However, I think pre is even better than pre-wrap in this case. We don't ever want breaks to occur because much of Comet Cache is based on line-delimited configuration options.

jaswrks pushed a commit to websharks/comet-cache-pro that referenced this issue Jan 27, 2017

jaswsinc
- **Bug Fix:** Apache detection sometimes inaccurate. So instead of u…
…sing default WP core globals for server detection, Comet Cache now uses it's own set of Apache/Nginx/IIS detection functions. And, this release enhances our Apache and Nginx detection routines; making them smart enough to catch additional edge cases; i.e., to further reduce the likelihood of there being a false-positive. See [Issue #748](websharks/comet-cache#748).

- **Bug Fix:** Some Jetpack API calls were being cached inadvertently. See [Issue #855](websharks/comet-cache#855).
- **Bug Fix:** Some XML-RPC and REST API requests were being cached inadvertently. See [Issue #855](websharks/comet-cache#855).
- **Bug Fix:** Some REST requests were being redirected incorrectly whenever Apache Optimizations were enabled. See [Issue #855](websharks/comet-cache#855).
- **Bug Fix:** Broken textarea field due to `white-space:nowrap` in Firefox. See [Issue #866](websharks/comet-cache#866).
- **Enhancement:** Notes in HTML source now indicate fully functional on first load for improved clarity. See [Issue #860](websharks/comet-cache#860).

raamdev added a commit that referenced this issue Feb 1, 2017

Phing release of v170201-RC with the following changes:
- **New Feature:** Comet Cache can now be configured to automatically clear the cache for date-based archive views whenever any single post is cleared due to changes in content, title, etc. See: **Dashboard → Comet Cache → Plugin Options → Automatic Cache Clearing → Auto-Clear "Date-Based Archives" Too?**. See also: [Issue #724](#724).
- **New Pro Feature:** Apache Optimizations now include a new option that allows site owners to enforce an exact host name for all requests. See: **Dashboard → Comet Cache Pro → Plugin Options → Apache Optimizations → Enforce an Exact Host Name?**. See also: [Issue #101](#101).
- **Bug Fix:** Apache detection sometimes inaccurate. So instead of using default WP core globals for server detection, Comet Cache now uses it's own set of Apache/Nginx/IIS detection functions. And, this release enhances our Apache and Nginx detection routines; making them smart enough to catch additional edge cases; i.e., to further reduce the likelihood of there being a false-positive. See [Issue #748](#748).
- **Bug Fix:** Some XML-RPC and REST API requests were being cached inadvertently. See [Issue #855](#855).
- **Bug Fix:** Broken textarea field due to `white-space:nowrap` in Firefox. See [Issue #866](#866).
- **Bug Fix:** This release resolves empty directories being left in the cache folder, in some scenarios. See [Thread #866](https://forums.wpsharks.com/t/cache-folders-not-removed-during-clean-up-process/866).
- **Bug Fix** (Pro): Some REST requests were being redirected incorrectly whenever Apache Optimizations were enabled. See [Issue #855](#855).
- **Compatibility Bug Fix:** Some Jetpack API calls were being cached inadvertently. See [Issue #855](#855).
- **Enhancement:** Notes in HTML source now indicate fully functional on first load for improved clarity. See [Issue #860](#860).
- **Code Cleanup:** Enhancing security by removing `basename(__FILE__)` from direct access notices.
@renzms

This comment has been minimized.

renzms commented Feb 3, 2017

Confirmed Working

Tested Using:

WordPress Version: 4.7.2
Current WordPress Theme: Twenty Seventeen version 1.1
Theme Author: the WordPress team - https://wordpress.org/
Theme URI: https://wordpress.org/themes/twentyseventeen/
Active Plugins: Comet Cache Comet Cache™ Pro v170201-RC
PHP Version: 7.0.10-2+deb.sury.org~xenial+1
MySQL Version: 10.0.29-MariaDB-0ubuntu0.16.04.1

FireFox: 51.0.1

Tested by attempting to fill-in multiple CDN Hostnames from a Network installation and going to the next line by pressing Enter.

screen shot 2017-02-03 at 8 58 32 pm

raamdev added a commit that referenced this issue Feb 20, 2017

Phing release of v170220 with the following changes:
- **New Feature:** Comet Cache can now be configured to automatically clear the cache for date-based archive views whenever any single post is cleared due to changes in content, title, etc. See: **Dashboard → Comet Cache → Plugin Options → Automatic Cache Clearing → Auto-Clear "Date-Based Archives" Too?**. See also: [Issue #724](#724).
- **New Pro Feature:** Apache Optimizations now include a new option that allows site owners to enforce an exact host name for all requests. See: **Dashboard → Comet Cache Pro → Plugin Options → Apache Optimizations → Enforce an Exact Host Name?**. See also: [Issue #101](#101).
- **Bug Fix:** Apache detection sometimes inaccurate. So instead of using default WP core globals for server detection, Comet Cache now uses it's own set of Apache/Nginx/IIS detection functions. And, this release enhances our Apache and Nginx detection routines; making them smart enough to catch additional edge cases; i.e., to further reduce the likelihood of there being a false-positive. See [Issue #748](#748).
- **Bug Fix:** Some XML-RPC and REST API requests were being cached inadvertently. See [Issue #855](#855).
- **Bug Fix:** Broken textarea field due to `white-space:nowrap` in Firefox. See [Issue #866](#866).
- **Bug Fix:** This release resolves empty directories being left in the cache folder, in some scenarios. See [Thread #866](https://forums.wpsharks.com/t/cache-folders-not-removed-during-clean-up-process/866).
- **Bug Fix** (Pro): Some REST requests were being redirected incorrectly whenever Apache Optimizations were enabled. See [Issue #855](#855).
- **Compatibility Bug Fix:** Some Jetpack API calls were being cached inadvertently. See [Issue #855](#855).
- **Enhancement:** Notes in HTML source now indicate fully functional on first load for improved clarity. See [Issue #860](#860).
- **Enhancement:** Enhancing security by removing `basename(__FILE__)` from direct access notices.
@raamdev

This comment has been minimized.

Member

raamdev commented Feb 20, 2017

Comet Cache v170220 has been released and includes changes from this GitHub Issue. See the v170220 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#866).

@raamdev raamdev closed this Feb 20, 2017

@websharks websharks locked and limited conversation to collaborators Feb 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.