New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment-Mail Email: UTF-8 "Branch Icon" Showing Up As Box #116

Closed
renzms opened this Issue Jul 11, 2015 · 10 comments

Comments

Projects
None yet
4 participants
@renzms
Contributor

renzms commented Jul 11, 2015

On the auto-sent email from Comment-Mail, a box appears next to the URL.

Please see screenshot :
image

Box appears next to url instead of Branch Icon which should look like this:
image

Temporary Solutions from Jason:

  • Check your system font to see if it is missing that UTF-8 glyph and perhaps update to a font that supports it.
  • Or, alter the default Comment Mail template file that controls the Email Header. This is available in the Comment Mail config. options under "Email Templates".

@jaswrks jaswrks added the bug label Jul 11, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 11, 2015

Thanks for reporting this compatibility issue! :-)

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jul 11, 2015

I would vote for just removing that glyph from the default email template and let the site URL line up underneath the site title. I don't see that glyph adding much value here.

More important than making the default email templates fancy is making them as widely-compatible as possible.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 11, 2015

I don't see that glyph adding much value here.

👍 Agree.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 15, 2015

Next Actions

Start a New Feature Branch

These instructions assume that you've already done a git clone, so you already have a copy of both the Comment Mail and Comment Mail Pro repos on your system.

Lite Version

$ cd ~/projects/websharks/comment-mail
$ git checkout 000000-dev # Start from the dev branch.
$ git pull # Make sure you have the most up-to-date copy.
$ git checkout -b feature/116 # New feature branch for this issue.
$ git status # Quick review. You should be on branch feature/116

Pro Version

$ cd ~/projects/websharks/comment-mail-pro
$ git checkout 000000-dev # Start from the dev branch.
$ git pull # Make sure you have the most up-to-date copy.
$ git checkout -b feature/116 # New feature branch for this issue.
$ git status # Quick review. You should be on branch feature/116

Make Changes

I'm pointing you to lines in the code as it exists on GitHub. However, you should make these changes in the files on your own system; using your favorite editor.

Lite Version

Pro Version


Commit & Push To GitHub

Lite Version

$ cd ~/projects/websharks/comment-mail
$ git status # Quick review. You should see the changed file appear in the list.
$ git add --all && git commit -m 'Removing incompatible branch icon entity. See: websharks/comment-mail#116'
$ git push -u origin feature/116

Pro Version

$ cd ~/projects/websharks/comment-mail-pro
$ git status # Quick review. You should see the changed files appear in the list.
$ git add --all && git commit -m 'Removing incompatible branch icon entities. See: websharks/comment-mail#116'
$ git push -u origin feature/116

Go to GitHub and submit Pull Requests

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 15, 2015

Assigning this to @kristineds

@raamdev raamdev modified the milestone: Next Release Jul 15, 2015

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Jul 16, 2015

@jaswrks jaswrks added in progress and removed ready for work labels Jul 16, 2015

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Jul 16, 2015

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Jul 16, 2015

JasWSInc
Merge pull request #3 from websharks/feature/116
Removing incompatible branch icon entities. See websharks/comment-mail#116

@jaswrks jaswrks removed the in progress label Jul 16, 2015

jaswrks pushed a commit that referenced this issue Jul 16, 2015

JasWSInc
Merge pull request #120 from websharks/feature/116
Removing incompatible branch icon entity. See #116
@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 16, 2015

Awesome. Two PRs from @kristineds merged into the dev branch. Thanks! :-)

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jul 16, 2015

Awesome. Two PRs from @kristineds merged into the dev branch. Thanks! :-)

Cool!! 👍

@raamdev

This comment has been minimized.

Contributor

raamdev commented Oct 8, 2015

Next Lite Release Changelog:

  • Bug Fix: Removed a UTF-8 "Branch Icon" in the default email templates that was not showing up properly in some email clients. Props @renzms @kristineds. See Issue #116.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Oct 8, 2015

Next Pro Release Changelog:

  • Bug Fix: Removed a UTF-8 "Branch Icon" in the default email templates that was not showing up properly in some email clients. Props @renzms @kristineds. See Issue #116.

@websharks websharks locked and limited conversation to collaborators Dec 24, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#116).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.