New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAN-SPAM U.S. Only (Allow Others to Disable) #122

Closed
jaswrks opened this Issue Jul 22, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@jaswrks
Member

jaswrks commented Jul 22, 2015

A fork of #118 (comment)

@jaswrks jaswrks added the bug label Jul 22, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 23, 2015

Next Actions

Prerequisites

This issue will require some basic knowledge of PHP. It will be a good learning experience. If you have any trouble editing the menu-page.php file referenced below, please ask for help on Slack :-)

Start New Feature Branch

I'll assume whoever works on this knows how to do this. If you need help or have forgotten, please let me know. Remember that a feature branch should follow the issue number; e.g., feature/122 for this issue.

Make Changes

Remove references to CAN-SPAM which is U.S. only.

The idea here is that we want to rename the title of this panel. It currently reads, "CAN-SPAM Compliance", but we should remove references to the CAN-SPAM Act in favor of a more generalized approach that will be more internationally relevant.

2015-07-23_05-49-21

Commit Changes

$ git add --all && git commit -m 'Rename CAN-SPAM section. See: websharks/comment-mail#122'

Push to GitHub

$ git push -u origin feature/122

Submit Pull Requests

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jul 23, 2015

Submitted PRs for Comment Mail Lite and Pro version.

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Jul 24, 2015

kristineds added a commit that referenced this issue Jul 24, 2015

kristineds added a commit that referenced this issue Jul 24, 2015

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jul 24, 2015

@jaswsinc Submitted PRs for Lite and Pro version. with updated changes. Please review. :)

@jaswrks jaswrks closed this in #126 Jul 24, 2015

jaswrks pushed a commit that referenced this issue Jul 24, 2015

@jaswrks jaswrks removed the in progress label Jul 24, 2015

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Jul 24, 2015

@raamdev raamdev added this to the Next Release milestone Jul 25, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Oct 8, 2015

Next Lite Release Changelog:

  • Enhancement: Removed references to "CAN-SPAM Act", which is a United States law that may not be understood or applicable to Comment Mail users outside of the United States. Props @Li-An and @kristineds. See Issue #122.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Oct 8, 2015

Next Pro Release Changelog:

  • Enhancement: Removed references to "CAN-SPAM Act", which is a United States law that may not be understood or applicable to Comment Mail users outside of the United States. Props @Li-An and @kristineds. See Issue #122.

@websharks websharks locked and limited conversation to collaborators Dec 24, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#122).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.