New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the text "Pro" on Comment Mail dashboard #131

Closed
kristineds opened this Issue Jul 27, 2015 · 13 comments

Comments

Projects
None yet
3 participants
@kristineds
Contributor

kristineds commented Jul 27, 2015

It would be nice to have the text (Pro) added after the word Comment Mail on the Dashboard so it is consistent with our other plugins like s2Member when upgraded to the Pro version. It is also easier for users to determine if they're using the Pro version without having to check the Plugin list.

Before:

screen shot 2015-07-27 at 11 28 41 am

After:

screen shot 2015-07-27 at 11 52 02 am

@kristineds kristineds added this to the Next Release milestone Jul 27, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 27, 2015

@kristineds I agree. That would be a nice touch!

The only problem I see is that it forces the line to wrap which is annoying; i.e., the name of the plugin is just a bit too long for us to fit (Pro) on the end without forcing it to wrap--given the default width of this bar in the WordPress Dashboard.

Perhaps we could work on building a second variation of our SVG plugin icon. One that has a little "pro" overlay. That could be enabled to help indicate that it's the pro edition of the plugin. Thoughts on that?

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jul 27, 2015

Another possibility: Add a + to indicate it's Comment Mail + all the Pro features:

2015-07-27_17-01-07

The Plugins list itself could still say "Comment Mail Pro"; the only place we'd use the Comment Mail+ would be on the menu itself (for space reasons).

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jul 28, 2015

@jaswsinc @raamdev Either one of your suggestions works for me. :)
Here is what it looks like with the text Pro as a superscript

screen shot 2015-07-28 at 11 03 29 pm

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 28, 2015

Love the superscript idea! Reducing the font size of that "Pro" label might make it even better.

Referencing: https://github.com/websharks/comment-mail-pro/blob/150709/comment-mail-pro/plugin.inc.php#L1199

$_menu_title = $this->name.' <sup style="font-size:80%;">Pro</sup>';

If you can make that work and test it, I'd love to have a PR we can merge into the pro copy.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jul 28, 2015

Here is what it looks like with the text Pro as a superscript

Brilliant! I love the superscript idea too.

<sup style="font-size:80%;

I suggest using 75%; 80% has issues when actually using the menu:

Superscript at 80%

2015-07-28_13-59-59
2015-07-28_14-00-40

Superscript at 75%

2015-07-28_13-59-45
2015-07-28_14-01-21

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jul 28, 2015

Also, adding the superscript pushes down the "Comment Mail" text:

2015-07-28_14-16-34

So you'll need to add the following CSS tweak to get the alignment fixed:

#adminmenu .toplevel_page_comment_mail div.wp-menu-name {
     padding-top: 3px;
}

2015-07-28_14-15-15

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jul 29, 2015

@raamdev @jaswsinc On what file can I add that CSS tweak for the padding? :) Is it this one? https://github.com/websharks/comment-mail-pro/blob/150709/comment-mail-pro/client-s/css/menu-pages.css

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 29, 2015

Let's see if you can get by without that, because the menu-pages.css file is not loaded for every admin page--only for pages that are for Comment Mail. I think if you set the line-height for the <sup> tag you can avoid this.

<sup style="font-size:60%; line-height:1;">Pro</sup>
@jaswrks

This comment has been minimized.

Member

jaswrks commented Jul 29, 2015

2015-07-29_10-02-37

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jul 29, 2015

<sup style="font-size:60%; line-height:1;">Pro</sup>

Confirmed. That works great on my end too!

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jul 29, 2015

Submitted PRs for CM Lite and Pro

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Jul 29, 2015

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Jul 29, 2015

JasWSInc
Merge pull request #9 from websharks/feature/131
UI Enhancement; updating plugin title. See: websharks/comment-mail#131

@jaswrks jaswrks removed the in progress label Jul 29, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Oct 8, 2015

Next Pro Release Changelog:

  • Enhancement: Added a "Pro" label to the plugin name to clearly indicate when the Pro version of Comment Mail is installed. Props @kristineds. See Issue #131.

@websharks websharks locked and limited conversation to collaborators Dec 24, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#131).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.