New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StCR Import Bug: "All Replies" subscriptions treated as "Replies Only To Self" #162

Closed
raamdev opened this Issue Nov 23, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@raamdev
Contributor

raamdev commented Nov 23, 2015

Steps to reproduce this bug

  1. Install, activate, and enable StCR
  2. Leave a comment on a post and select "All" to receive notifications for all new comments on the post
  3. Install, activate, and enable Comment Mail Lite (confirmed with v150709)
  4. Run the StCR → Comment Mail import process to import the StCR subscription
  5. Disable StCR
  6. Leave a new comment on the post that contained the subscription you imported

Expected behavior

Comment Mail should send a notification to the imported subscription.

Observed behavior

No email is sent.


What appears to be happening

If you edit the imported StCR subscription inside Comment Mail → Subscriptions, you'll notice how it appears to have been imported as a "replies only" subscription (because a Comment ID is selected). However, what's really strange is that the comment selected is itself.

In the screenshot below you can see that the comment selected in "Comment ID" is the same as the subscription being edited!

2015-11-23_16-31-33

@raamdev raamdev referenced this issue Nov 23, 2015

Closed

Finalize StCR → Comment Mail Migration Process #80

9 of 9 tasks complete

@raamdev raamdev added this to the Next Release milestone Nov 25, 2015

jaswrks pushed a commit that referenced this issue Dec 1, 2015

@jaswrks jaswrks referenced this issue Dec 1, 2015

Merged

PR: feature/162 #165

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Dec 1, 2015

@jaswrks jaswrks referenced this issue Dec 1, 2015

Merged

PR: feature/162 #31

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Dec 1, 2015

jaswrks pushed a commit that referenced this issue Dec 1, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 1, 2015

Next Release Changelog:

  • StCR Import Bug Fix: This release corrects an StCR importation bug. The bug was causing an existing StCR subscription with a Y status (i.e., one for all comments/replies) to be imported into Comment Mail on a per-comment basis. Therefore, a symptom of this bug was to find that you had multiple subscriptions imported for users who wanted all comments, instead of them just having one subscription imported which would automatically cover the entire post. Props @raamdev for reporting this. See also this GitHub issue for technical details.

@jaswrks jaswrks closed this Dec 1, 2015

@jaswrks jaswrks removed the ready for work label Dec 1, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 1, 2015

However, what's really strange is that the comment selected is itself.

@raamdev I found no correlation between the comment ID and the subscription ID. I think that may have just been a coincidence. I noticed this happening too, but it was only because I had a new install to test with and the likelihood of that occurring was higher; i.e., number of comments matches the total number of subscriptions recorded by CM during testing.

@jaswrks jaswrks reopened this Dec 1, 2015

@jaswrks jaswrks closed this Dec 1, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 1, 2015

Summary of StCR Import Behavior

  • If the existing subscription has a Y (all comments) status, one new subscription is imported for that subscriber; i.e., they are subscribed to all comment/replies on a given post.
  • If an existing subscriber has no Y status, or has any R (replies only) status, instead of subscribing the user to all comments/replies, we import subscriptions on a per-comment basis, and they are only subscribed to comments where they were the original author.
@Reedyseth

This comment has been minimized.

Contributor

Reedyseth commented Dec 1, 2015

Is this related to #166 ?

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#162).

@websharks websharks locked and limited conversation to collaborators Dec 24, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.