New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress v4.4 Compat #170

Closed
jaswrks opened this Issue Dec 5, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@jaswrks
Member

jaswrks commented Dec 5, 2015

Overview

WordPress v4.4 introduces some new objects for WP_Term and WP_Comment. This is mostly OK with Comment Mail. However, it recently came to my attention that in PHP 7.0 there are some flags being thrown with respect to type hints that are looking for \stdClass instances instead of the new WP_Comment class.

What needs to change?

We need to search the codebase for \stdClass $comment and remove \stdClass.

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Dec 5, 2015

@jaswrks jaswrks referenced this issue Dec 5, 2015

Closed

PR: feature/170 #34

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Dec 5, 2015

jaswrks pushed a commit that referenced this issue Dec 5, 2015

@jaswrks jaswrks self-assigned this Dec 5, 2015

@jaswrks jaswrks added this to the Next Release milestone Dec 5, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 6, 2015

@raamdev raamdev closed this Dec 6, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 6, 2015

Next Release Changelog:

  • Bug Fix: Fixed a compatibility bug with WordPress v4.4. Props @jaswsinc. See Issue #170.
@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 10, 2015

@raamdev I'm noting that this issue seems to impact all versions of PHP. Not just PHP 7+. So for that reason, this issue is likely to break existing installations of WP that are upgraded to WP v4.4 where the WP_Comment class exists.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 10, 2015

Not just PHP 7+

So this is entirely a WordPress v4.4 compatibility issue, i.e., Comment Mail is currently broken on WP 4.4 + any version of PHP?

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 10, 2015

Correct. However, it's not something that totally breaks the site, or that you're going to notice as soon as you upgrade. From what I've seen in the lite version, it only occurs whenever you change the status of a comment.

Catchable fatal error: Argument 3 passed to comment_mail\plugin::comment_status() must be an instance of stdClass, instance of WP_Comment given in /home4/wsksdev/public_html/jason/wp-content/plugins/comment-mail/plugin.inc.php on line 2218
@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 10, 2015

Updated changelog entry to indicate that this was a bug fix for WP v4.4:

  • Bug Fix: Fixed a compatibility bug with WordPress v4.4. Props @jaswsinc. See Issue #170.

@websharks websharks locked and limited conversation to collaborators Dec 24, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#170).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.