New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Default Options doesn't restore default options #181

Closed
raamdev opened this Issue Dec 15, 2015 · 9 comments

Comments

Projects
None yet
3 participants
@raamdev
Contributor

raamdev commented Dec 15, 2015

Testing the dev branch (as of 2015-12-15) of Comment Mail Pro, clicking "Restore Default Options" doesn't actually restore any default options. You can test this by enabling the plugin or disabling data safeguards, saving options, and then clicking "Restore Default Options". The defaults (Comment Mail disabled, Data Safeguards enabled) should be restored, but they are not.

@raamdev raamdev added the bug label Dec 15, 2015

@raamdev raamdev added this to the Next Release milestone Dec 15, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 15, 2015

This probably also affects Comment Mail Lite, but I haven't confirmed yet.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 15, 2015

Try changing this line. Instead of '1' use:

$args = array(__NAMESPACE__ => array('restore_default_options' => time()));

I think this is a browser caching quirk. The redirection is getting cached.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 15, 2015

I think this is a browser caching quirk. The redirection is getting cached.

I think you're right. I realized I was testing on my personal site, where there are quite a few plugins. I just tested on my clean install and the Restore Defaults works fine.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 15, 2015

Try changing this line. Instead of '1' use:

Confirmed. This fixes the issue.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 15, 2015

@renzms Could you submit a PR for me? For both Pro and Lite.

@renzms

This comment has been minimized.

Contributor

renzms commented Dec 15, 2015

@raamdev PRs submitted!

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 17, 2015

Next Lite Release Changelog:

  • Bug Fix: Fixed a bug with "Restore Default Options" that was introducing a browser quirk that was preventing the default options from being restored. Props @renzms. See Issue #181.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 17, 2015

Next Pro Release Changelog:

  • Bug Fix: Fixed a bug with "Restore Default Options" that was introducing a browser quirk that was preventing the default options from being restored. Props @renzms. See Issue #181.

@raamdev raamdev closed this Dec 17, 2015

@websharks websharks locked and limited conversation to collaborators Dec 24, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#181).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.