New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Comment Mail is disabled" notice margin is missing #186

Closed
raamdev opened this Issue Dec 21, 2015 · 12 comments

Comments

Projects
None yet
4 participants
@raamdev
Contributor

raamdev commented Dec 21, 2015

The .notice-warning class that is used for the "Comment Mail is disabled" notice needs the following style to fix alignment issues:

margin: 1.25em 1.25em 1.25em .25em;

2015-12-20_22-16-28
2015-12-20_22-16-48

@raamdev raamdev added the bug label Dec 21, 2015

@raamdev raamdev modified the milestones: Future Release, Next Release Dec 21, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 23, 2015

Note that this needs to be changed in both Comment Mail Lite and Comment Mail Pro.

@renzms

This comment has been minimized.

Contributor

renzms commented Dec 23, 2015

PRs submitted! 👍

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 23, 2015

@renzms Thank you! I tested your PR and confirmed the Disabled notice is now aligned properly:

2015-12-23_10-46-18

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 23, 2015

One thing I did notice during testing is that when you visit the Subscribe to Comments Reloaded options page, the StCR menu at the top clashes with these two Dashboard notices generated by Comment Mail:

2015-12-23_10-42-33
2015-12-23_10-42-53

This is really the fault of StCR and not Comment Mail, however given that new Comment Mail users who are migrating from StCR are likely to visit their StCR options page, I feel we should at least attempt to fix this clash to make the issue not quite as obvious.

I'm pushing a fix to the PRs submitted by @renzms that will resolve this issue on the StCR options page:

2015-12-23_10-49-28

raamdev added a commit to websharks/comment-mail-pro that referenced this issue Dec 23, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 23, 2015

Next Lite Release Changelog:

  • Bug Fix: Fixed a UI bug where some of the Dashboard notices generated by Comment Mail were either misaligned or were clashing with the Subscribe to Comments Reloaded options menu. Props @renzms. See Issue #186.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 23, 2015

Next Pro Release Changelog:

  • Bug Fix: Fixed a UI bug where some of the Dashboard notices generated by Comment Mail were either misaligned or were clashing with the Subscribe to Comments Reloaded options menu. Props @renzms. See Issue #186.

@raamdev raamdev closed this Dec 23, 2015

@websharks websharks locked and limited conversation to collaborators Dec 24, 2015

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#186).

@Reedyseth

This comment has been minimized.

Contributor

Reedyseth commented Dec 27, 2015

Guys just FYI,

This Dashes are removed and included on my latest changes of StCR.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 27, 2015

@Reedyseth Can you point me to the commit on GitHub where you made that change in StCR?

@Reedyseth

This comment has been minimized.

Contributor

Reedyseth commented Dec 29, 2015

Can you point me to the commit on GitHub where you made that change in StCR?

Sure, they are on a development branch on this commit stcr/subscribe-to-comments-reloaded@ec65388

@ the file subscribe-to-comments-reloaded/style.css

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 29, 2015

This Dashes are removed and included on my latest changes of StCR.

Copy that. Thanks.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Dec 29, 2015

@Reedyseth The problem isn't the dashed style; the problem is that the <h2> element that the StCR links are inside are overflowing onto Divs that show up underneath it.

I've opened a new GitHub issue with screenshots on the StCR repo, along with a suggested way of fixing the problem (that I've tested); see stcr/subscribe-to-comments-reloaded#158.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.