New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show installed version number on plugin options panels #187

Closed
raamdev opened this Issue Dec 21, 2015 · 12 comments

Comments

Projects
None yet
3 participants
@raamdev
Contributor

raamdev commented Dec 21, 2015

It would be nice to show the installed plugin version right inside the plugin options page along with a link to the changelog:

2015-12-20_22-27-03

@raamdev raamdev added the enhancement label Dec 21, 2015

@raamdev raamdev added this to the Future Release milestone Dec 21, 2015

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jan 2, 2016

@raamdev Do you want to add it in the same way as what was done with ZC?

  • show both the installed version number and the 'latest' version number, if different.
  • show something like "Upgrade now" if there's a newer version.

On a different note, I feel like all those options below the Comment Mail logo feels a bit crowded, imo. :) What you have with ZC looks more organized and clean (i.e. the options for Pro Upgrade, Newsletter, Preview Pro features are placed on the upper right side). cc @jaswsinc

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 2, 2016

Do you want to add it in the same way as what was done with ZC?

Yes, that sounds great!

On a different note, I feel like all those options below the Comment Mail logo feels a bit crowded, imo. :) What you have with ZC looks more organized and clean (i.e. the options for Pro Upgrade, Newsletter, Preview Pro features are placed on the upper right side). cc @jaswsinc

I totally agree. That has been bugging me for awhile. It feels like the least-polished part of Comment Mail that you use on a regular basis (and the first time you use it, those options are not obvious at all--we improved this in #112).

What I'd really love to see in place of what we have now is a tabbed system, something that looks like this but also includes the icons that we have now:

2016-01-02_12-29-23

Many plugins use a similar tabbed style, StCR and WP Super Cache being the two that immediately come to mind, so users are likely to already be familiar with it.

@jaswsinc Any objection to implementing a tabbed-style for those options?

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 3, 2016

@raamdev Sounds cool. I have no objections.

@raamdev raamdev referenced this issue Jan 3, 2016

Closed

[duplicate] #197

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 3, 2016

After putting a bit more thought into this, my feeling now is that we don't need a tabbed system at all. In fact, we can just clean things up so that there aren't so many items there.

2016-01-03_13-54-11

Instead of turning those items into a tabbed system, why don't we just remove the items that really don't belong there and use something more like what we have in ZenCache:

2016-01-03_14-02-35

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jan 15, 2016

@jaswsinc @raamdev I was able to move the sub-section menu items but I'm having a hard time adding the version number and Pro Updater link on the PRO version. Would need your guidance on this. :)

I have this so far..

  • To display plugin version number: After this line, add this:
$heading .= '  <div class="pmp-version">'."\n";
$heading .= '     <span> '.__('%1$s&trade; Pro v%2$s', $this->plugin->text_domain), esc_html($this->plugin->name), esc_html($this->plugin->version).'</span>'."\n";
$heading .= '  </div>'."\n";
  • To display Pro Updater Link: After this line, add this:
if(!$this->plugin->is_pro) // Display pro updater
{
$heading .= '  <a href="'.esc_attr($this->plugin->utils_url->pro_updater_menu_page_only()).'"'.
($this->plugin->utils_env->is_pro_updater_menu_page_only() ? ' class="pmp-active"' : '').'>'.
'<i class="fa fa-magic"></i> '.__('Pro Updater', $this->plugin->text_domain).'</a>'."\n";
}
@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 18, 2016

@kristineds It looks all you're missing here is the sprintf() call.

$heading .= '  <div class="pmp-version">'."\n";
$heading .= '     <span> '.sprintf(__('%1$s&trade; Pro v%2$s', $this->plugin->text_domain), esc_html($this->plugin->name), esc_html($this->plugin->version)).'</span>'."\n";
$heading .= '  </div>'."\n";

See also: http://php.net/manual/en/function.sprintf.php

Note that sprintf() is what handles the %1$s and %2$s replacement codes.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 18, 2016

@kristineds This function does not exist to my knowledge.

$this->plugin->utils_env->is_pro_updater_menu_page_only()

You can use this instead, which does exist:

$this->plugin->utils_env->is_menu_page(__NAMESPACE__.'_pro_updater')

See also: https://github.com/websharks/comment-mail-pro/blob/8d9fce347e009ff6d6d2e5946581e22c4338af60/comment-mail-pro/includes/classes/utils-env.php#L87-L120

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 25, 2016

@kristineds Just checking in here. Anything not clear enough? If so just give us a shout! :-)

@kristineds kristineds self-assigned this Jan 26, 2016

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Jan 26, 2016

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Jan 26, 2016

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Jan 26, 2016

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Feb 4, 2016

kristineds added a commit that referenced this issue Feb 6, 2016

kristineds added a commit to websharks/comment-mail-pro that referenced this issue Feb 6, 2016

kristineds added a commit that referenced this issue Feb 6, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 8, 2016

Lite

2016-02-08_10-43-07

Pro

2016-02-08_10-43-44

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 8, 2016

Next Lite Release Changelog:

  • Enhancement: Added the installed version number to the plugin options pages. Props @kristineds. See Issue #187.
  • Enhancement: Improved the organization of navigation links on the plugin options pages. Props @kristineds. See Issue #187.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 8, 2016

Next Pro Release Changelog:

  • Enhancement: Added the installed version number to the plugin options pages. Props @kristineds. See Issue #187.
  • Enhancement: Improved the organization of navigation links on the plugin options pages. Props @kristineds. See Issue #187.

@raamdev raamdev closed this Feb 8, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 13, 2016

Comment Mail v160213 has been released and includes changes from this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#187).

@websharks websharks locked and limited conversation to collaborators Feb 13, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.