New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary quotes from front-end pages and email templates #201

Closed
raamdev opened this Issue Jan 11, 2016 · 17 comments

Comments

Projects
None yet
4 participants
@raamdev
Contributor

raamdev commented Jan 11, 2016

@RealDavidoff writes in #199 (comment)...

  1. Return to "website name" - Why the " " ?? Leave out, makes no sense, you are not quoting us. Same here: You'll be notified about all comments/replies to: "German Shepherd Dog Training" - it's linked, quotes are needless if not irritating (quotes are used to, well, QUOTE someone!)
@renzms

This comment has been minimized.

Contributor

renzms commented Jan 24, 2016

@raamdev Hi Raam, PR submitted, do I need to repeat for Pro? Or do they have the same templates?

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 25, 2016

I just want to go on record as disagreeing with this change request. It's common practice to quote titles, particularly when it would be easy to misunderstand that it is a title. Since a Post can potentially have a strange title, quoting it helps to ensure that someone can see it is all one entity; i.e., a title.

If quotes are not desirable, then I suggest an alternative approach. In either case though, it should be easy to see that the title is a full string of words that are separate from the wording used around it.

Imagine a Post with the title...

Return to Paradise

Now incorporate that into a sentence as seen above...

Return to "Return to Paradise"

is far less confusing than...

Return to Return to Paradise

Removing the quotes could potentially lead to more confusion, not less.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 25, 2016

I suggest the use of italics instead of quotes.

@RealDavidoff

This comment has been minimized.

RealDavidoff commented Jan 25, 2016

To repeat: I was saying there must not be any quotes around the website NAME and similar items. While "It's common practice to quote titles", yes, it's misleading to "quote" a NAME (here the website). Have you ever seen, say the NY Times etc, to write:
According to "Bill Gates" quotes around names are helpful.
:-)
You only quote, well, QUOTES. S.o. said sth. Or here, s.o. wrote sth, eg a title, yes.
Clear now?

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 25, 2016

@renzms Please update your PRs (yes, we need PRs for Lite and Pro) with the following:

  • Add <em></em> tags wherever there were quotes to help emphasis the Title / Blog Name now that the quotes are gone.
@RealDavidoff

This comment has been minimized.

RealDavidoff commented Jan 25, 2016

It's ridiculous, but I never saw ANY mention of websharks FROM websharks where you felt the need to put your own name in italics or in quotes!

what a time-waste for me when trying to help/open eyes...

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 25, 2016

@RealDavidoff What is the problem? You asked us to fix something and we're fixing it. It's hard to help when you don't want to see that we're doing exactly as you asked.

@RealDavidoff

This comment has been minimized.

RealDavidoff commented Jan 25, 2016

But you aren't. Just read it tomorrow, afresh.

On 25 January 2016 at 17:51, Raam Dev notifications@github.com wrote:

@RealDavidoff https://github.com/RealDavidoff What is the problem? You
asked us to fix something and we're fixing it. It's hard to help when you
don't want to see that we're doing exactly as you asked.


Reply to this email directly or view it on GitHub
#201 (comment)
.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 26, 2016

@RealDavidoff If my comment felt personal, it was not. I assure you. I respect and appreciate your feedback here, and you have pointed out several ways that we can improve. Props!

However, working through issues in code, contemplating other angles, these are things that require various people and respect for differing opinions. Statements like, "It's ridiculous", and "what a time-waste for me", is not you looking at the problem objectively and showing respect for the feedback that I have about this. This is about the end result. No quotes, italics instead. That's an improvement. One that is coming about as a result of feedback we got from you. Thanks!

You replied...

To repeat: I was saying there must not be any quotes around the website NAME and similar items. While "It's common practice to quote titles", yes, it's misleading to "quote" a NAME (here the website). Have you ever seen, say the NY Times etc, to write:

It's the similar items that we are working with right now.

For instance, you suggested previously...

Same here: You'll be notified about all comments/replies to: "German Shepherd Dog Training"

Right now we are working with titles.

@renzms

This comment has been minimized.

Contributor

renzms commented Jan 26, 2016

@raamdev @jaswsinc > Please update your PRs (yes, we need PRs for Lite and Pro) with the following:

Add tags wherever there were quotes to help emphasis the Title / Blog Name now that the quotes are gone.

Got it, will update for Pro and Lite and use italics in place of the quotes for emphasis.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 26, 2016

@RealDavidoff writes...

But you aren't. Just read it tomorrow, afresh.

Yes, please read it afresh tomorrow and you'll see that we are, in fact, doing exactly as you asked: Removing quotes. They are being replaced with <em> tags, which are not quotes. The <em> tags will make the titles italic so that they stand separate from any text that may proceed them.

@renzms

This comment has been minimized.

Contributor

renzms commented Jan 26, 2016

@raamdev

Submit PR for both Pro and Lite for review. Thanks!

renzms added a commit that referenced this issue Jan 27, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 1, 2016

@renzms It looks like you missed the /includes/templates/type-a/ templates in the Pro version in this PR. I realized that after merging the PR, so please open another PR, feature/201a, and submit those same changes except for type-a templates.

@renzms

This comment has been minimized.

Contributor

renzms commented Feb 2, 2016

@raamdev

Hi, updated for type A. Ready for review, thanks!

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 3, 2016

Next Lite Release Changelog:

  • Enhancement: Improved front-end pages and email templates by using <em> (emphasis) tags instead of quotation marks in various areas. Props @RealDavidoff @renzms. See Issue #201.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 3, 2016

Next Pro Release Changelog:

  • Enhancement: Improved front-end pages and email templates by using <em> (emphasis) tags instead of quotation marks in various areas. Props @RealDavidoff @renzms. See Issue #201.
@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 13, 2016

Comment Mail v160213 has been released and includes changes from this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#201).

@websharks websharks locked and limited conversation to collaborators Feb 13, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.