New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v160211-RC: Email template includes <em> tags in subject #232

Closed
raamdev opened this Issue Feb 12, 2016 · 5 comments

Comments

Projects
None yet
1 participant
@raamdev
Contributor

raamdev commented Feb 12, 2016

It looks like some of the email templates that were updated in #201 inadvertently had subject lines changed to include <em> tags. Email subject lines won't process HTML.


2016-02-12_09-46-52


I suggest we change the subject line to "Confirm your subscription: [Post TItle]" and get rid of quotes in the subject line altogether.

Also, the italic Post Title in the body of this email doesn't look right. If the Post Title appears on a line all by itself, it doesn't need to be italic or have double-quotes. Being on a line all by itself is emphasis enough.

@raamdev raamdev added the bug label Feb 12, 2016

@raamdev raamdev added this to the Next Release milestone Feb 12, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 12, 2016

Italics here is also unnecessary, since the title is on a line by itself:

2016-02-12_09-59-10

@raamdev raamdev self-assigned this Feb 12, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 12, 2016

I've started working on this.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 12, 2016

@jaswsinc I'm looking at the various snippets used in the subject lines and my feeling is that the best way to make them look good and easily separate from the title of the post (because we have no idea what that may contain) would be to follow WordPress' lead and do what they do for WordPress.com subscriptions: Enclose the meta information in brackets.

[New Replies to Your Comment] How to Understand Life, Love and Yourself
[New Comments] How to Understand Life, Love and Yourself
[New Reply to Your Comment] How to Understand Life, Love and Yourself
[New Reply to Comment ID #3523] How to Understand Life, Love and Yourself

The subscription confirmation email subject would be this:

Confirm subscription: How to Understand Life, Love and Yourself

If you don't have any major objections to this, I'm going to go ahead and update this.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 13, 2016

@raamdev raamdev closed this Feb 13, 2016

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 13, 2016

Comment Mail v160213 has been released and includes changes from this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#232).

@websharks websharks locked and limited conversation to collaborators Feb 13, 2016

@raamdev raamdev removed their assignment Apr 28, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.