New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: SparkPost for RVE #265

Closed
raamdev opened this Issue Apr 14, 2016 · 20 comments

Comments

Projects
None yet
7 participants
@raamdev
Contributor

raamdev commented Apr 14, 2016

Mandrill has announced that it's no longer going to be free which means Comment Mail's RVE feature will soon depend on a paid-only service (see #240).

SparkPost, a similar service, has announced that it will "honor Mandrill’s pricing for any customer that switches to SparkPost from Mandrill". See the Mandrill Migration Guide.

I suggest that we prioritize SparkPost as a replacement for Mandrill. They have a free plan and the free plan (as far as I can tell) supports relay webhooks.

Here are the API Docs for their Relay Webhooks:
https://developers.sparkpost.com/api/#/reference/relay-webhooks

@yepher

This comment has been minimized.

yepher commented Apr 14, 2016

If you have any questions during your migration consider reaching out on SparkPost's developer Slack channel. You can join here

There are developer there who can help answer integration questions.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Apr 14, 2016

@yepher Awesome. Thanks for the tip! We use Slack at WebSharks too, so that should make things easy. :-)

@raamdev raamdev added this to the Future Release milestone May 17, 2016

@JeffVark

This comment has been minimized.

JeffVark commented Jul 6, 2016

I've been using Sparkpost since the Mandrill announcement. They have a great offer. Sparkpost would be an excellent choice for the Comment Mail's RVE feature.

@raamdev raamdev modified the milestones: Next Release, Future Release Jul 19, 2016

@kristineds

This comment has been minimized.

Contributor

kristineds commented Sep 29, 2016

Also requested here: Private Support Ticket #14930.

@kristineds kristineds referenced this issue Sep 29, 2016

Open

Mandrill RVE Handler #7

6 of 6 tasks complete
@jaswrks

This comment has been minimized.

Member

jaswrks commented Oct 11, 2016

Estimate at three days.

@tech55541

This comment has been minimized.

tech55541 commented Oct 24, 2016

Can't wait to see this.

@kristineds

This comment has been minimized.

Contributor

kristineds commented Oct 24, 2016

Also requested here: Private Support Ticket #14696.

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 2, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 2, 2016

jaswsinc

@jaswrks jaswrks referenced this issue Nov 3, 2016

Merged

PR: feature/265 #89

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 3, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 3, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 3, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc
@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 4, 2016

Next Release Changelog:

  • SparkPost Integration: It is now possible to use SparkPost for Replies-via-Email (RVE) instead of Mandrill. Note that SparkPost is now the suggested RVE Handler for Comment Mail because Mandrill changed its pricing structure a while back. In short, Mandrill requires a fee, whereas SparkPost (recommended) offers Relay Webhooks as a part of their free plan. See also issue #265 for additional details.

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 4, 2016

jaswsinc

@raamdev raamdev removed the ready for work label Nov 9, 2016

@raamdev raamdev assigned renzms and unassigned jaswrks Nov 10, 2016

@renzms

This comment has been minimized.

Contributor

renzms commented Nov 10, 2016

@raamdev @jaswsinc

Hi Guys, Observed a fatal Error and the links to the documentation were not working while testing this.


@jaswsinc

Side Note, for the test domains you've setup for us, in the documentation its noted that there is no SPF Text Record or DKIM Record available. Is it possible to add the following emails to verify for SparkPost?

VERIFY EMAIL
abuse@name.domain.net 
postmaster@name.domain.net
@renzms

This comment has been minimized.

Contributor

renzms commented Nov 10, 2016

@raamdev @jaswsinc

Hi Guys, Observed a fatal Error and the links to the documentation were not working while testing this.


Observed Behaviour: Fatal Error on all white page

Fatal error: Uncaught Error: Using $this when not in object context in /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/RveSparkPost.php on line 271 Error: Using $this when not in object context in /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/RveSparkPost.php on line 271 Call Stack: 0.0003 406200 1. {main}() /app/src/wp-admin/admin.php:0 0.0004 406680 2. require_once('/app/src/wp-load.php') /app/src/wp-admin/admin.php:31 0.0008 421040 3. require_once('/app/src/wp-config.php') /app/src/wp-load.php:39 0.0010 424600 4. require_once('/app/src/wp-settings.php') /app/src/wp-config.php:41 0.0731 3531072 5. do_action() /app/src/wp-settings.php:411 0.0731 3531472 6. WebSharks\CommentMail\Pro\Plugin->actions() /app/src/wp-includes/plugin.php:524 0.0737 3543296 7. WebSharks\CommentMail\Pro\Actions->__construct() /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/Plugin.php:1034 0.0738 3543416 8. WebSharks\CommentMail\Pro\Actions->maybeDoMenuPageActions() /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/Actions.php:41 0.0754 3712312 9. WebSharks\CommentMail\Pro\MenuPageActions->__construct() /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/Actions.php:107 0.0755 3713128 10. WebSharks\CommentMail\Pro\MenuPageActions->maybeHandle() /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/MenuPageActions.php:55 0.0853 4263568 11. WebSharks\CommentMail\Pro\MenuPageActions->saveOptions() /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/MenuPageActions.php:79 0.0855 4263568 12. WebSharks\CommentMail\Pro\Plugin->optionsSave() /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/MenuPageActions.php:99 0.1353 4504672 13. WebSharks\CommentMail\Pro\RveSparkPost::setupWebhook() /app/src/wp-content/plugins/comment-mail-pro/src/includes/classes/Plugin.php:1152

Steps to Reproduce Fatal Error

  • Enable Comment Mail Pro, and setup SparkPost account to get API
  • Choose SparkPost in the dropdown for RVE Handler, and input API and email into corresponding fields under RVE Handler panel
  • Click Save all changes
  • Fatal Error after submission redirect

SparkPost KBA links

screen shot 2016-11-10 at 4 58 54 pm

Both links go to http://comment-mail.com/kb-article/sparkpost-rve-handler/

screen shot 2016-11-10 at 4 46 36 pm


@jaswsinc

Side Note, for the test domains you've setup for us, in the documentation its noted that there is no SPF Text Record or DKIM Record available. Is it possible to add the following emails to verify for SparkPost?

VERIFY EMAIL
abuse@name.domain.net 
postmaster@name.domain.net

jaswrks pushed a commit to websharks/comment-mail-pro that referenced this issue Nov 10, 2016

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 10, 2016

Using $this when not in object context

Fixed in dev branch. Thank you.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 10, 2016

@renzms Great catch BTW. Thanks! :-)

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 10, 2016

@renzms The KBA is still in draft format here, for now:
websharks/comment-mail-kb#27

@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 10, 2016

@renzms writes...

that there is no SPF Text Record or DKIM Record available

This would be for your Outbound Sending Domain, which is not necessary to configure for the purpose of testing Comment Mail. So you can just ignore that message. Having said that, I did try to set up the @wpsharks.net domain for this purpose, but that appears to be probelmatic when it comes to SparkPost Sending Domains, due to the fact that they do not allow sub-domains under the same top-level domain to be used across multiple test accounts.

⭐️ What I was able to do is setup the MX record for an Inbound Domain, which is what's needed to test Comment Mail. For the SparkPost RVE Reply-To address in Comment Mail you can use:

rve@spark-renz.wpsharks.net

See also: websharks/comment-mail-kb#27

@renzms

This comment has been minimized.

Contributor

renzms commented Nov 10, 2016

What I was able to do is setup the MX record for an Inbound Domain, which is what's needed to test Comment Mail. For the SparkPost RVE Reply-To address in Comment Mail you can use:

Thanks! I will build again using the changes you made on the dev branch and test.

@renzms

This comment has been minimized.

Contributor

renzms commented Nov 10, 2016

@jaswsinc

Testing the latest dev build and following the instructions found in: websharks/comment-mail-kb#27

Good news is I no longer receive the fatal error message.

However,...

I received the following error prompt:

RVE Error: The Comment Mail™ plugin was unable to complete the integration with SparkPost. When attempting to create a Relay Webhook the SparkPost API said:
resource conflict
@jaswrks

This comment has been minimized.

Member

jaswrks commented Nov 10, 2016

@renzms Can you post a screenshot of the RVE config fields that returned this error please?

@renzms

This comment has been minimized.

Contributor

renzms commented Nov 10, 2016

@jaswsinc

Sure

RVE Panel

screen shot 2016-11-10 at 10 57 51 pm

SparkPost Dashboard

screen shot 2016-11-10 at 10 53 42 pm

@renzms

This comment has been minimized.

Contributor

renzms commented Nov 10, 2016

@raamdev @jaswsinc

Comments via RVE are now working.

I can confirm this is working now with the latest dev build. Thanks @jaswsinc for clearing the Webhook from SparkPost so I could get this working!

raamdev added a commit that referenced this issue Nov 18, 2016

Phing release of v161118 with the following changes:
- **Bug Fix:** Exclude unapproved comments from the dropdown menu on the 'Subscribe Without Commenting' form. See [Issue #299](#299).
- **Enhancement:** When parsing templates, this release uses `include()` instead of `eval()` whenever possible. This improves compatibility with shared hosting providers and makes it easier to debug template parsing issues should they occur. See [Issue #192](#192).
- **PHP v7 Compatibility:** After further testing, it was found that while Comment Mail is compatible with PHP v7.0, you must be running PHP v7.0.9+. Starting with this release of Comment Mail if you're running PHP v7 < 7.0.9 a warning is displayed in the WordPress Dashboard asking the site owner to upgrade to PHP v7.0.9 or higher. Note: While PHP v7.0.9 is adequate, PHP v7.0.10 is strongly recommended. See [Issue #272](#272).
- **New SparkPost Integration** (Pro):  It is now possible to use SparkPost for Replies-via-Email (RVE) instead of Mandrill. Note that SparkPost is now the suggested RVE Handler for Comment Mail because Mandrill changed its pricing structure a while back. In short, Mandrill requires a fee, whereas SparkPost (recommended) offers Relay Webhooks as a part of their free plan. See [Issue #265](#265).
- **New Feature** (Pro): Adding support for MailChimp integration. It is now possible to give users the option of subscribing to your site-wide mailing list whenever they leave a comment or reply; i.e., in addition to subscribing to comment reply notifications they can also join your MailChimp mailing list. See [Issue #114](#114).
@raamdev

This comment has been minimized.

Contributor

raamdev commented Nov 18, 2016

Comment Mail v161118 has been released and includes changes from this GitHub Issue. See the v161118 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#265).

@raamdev raamdev closed this Nov 18, 2016

@websharks websharks locked and limited conversation to collaborators Nov 18, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.